Bug 1883769: Add validation for logLevel by dmage · Pull Request #353 · openshift/cluster-authentication-operator

dmage · 2020-09-29T10:03:40Z

openshift/api#736 added restrictions for logLevel values. This PR vendors new openshift/api to get new CRDs.

openshift-ci-robot · 2020-09-29T10:03:46Z

@dmage: This pull request references Bugzilla bug 1878040, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1878040: Add validation for logLevel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2020-09-29T10:05:13Z

/lgtm
/approve

openshift-bot · 2020-09-29T11:37:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T11:50:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sttts · 2020-09-29T12:05:02Z

/hold

sttts · 2020-09-29T15:09:06Z

/lgtm
/hold cancel

openshift-ci-robot · 2020-09-29T15:09:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sttts · 2020-09-29T15:52:38Z

/retest

openshift-bot · 2020-09-29T18:33:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T18:59:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T20:04:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T22:01:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T22:14:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T23:32:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T23:45:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T01:49:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T02:02:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T13:50:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T16:11:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T16:24:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T18:34:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T21:09:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-30T23:19:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T02:21:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T03:39:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T06:41:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T07:07:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T08:25:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T09:04:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T09:56:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T11:40:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T13:37:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T14:55:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T16:13:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T16:26:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T19:02:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T20:59:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T22:30:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T00:14:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T01:45:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T01:58:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T03:29:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-02T03:42:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-10-02T07:25:49Z

@dmage: All pull requests linked via external trackers have merged:

openshift/cluster-authentication-operator#353

Bugzilla bug 1883769 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1883769: Add validation for logLevel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot requested review from deads2k and stlaz September 29, 2020 10:04

openshift-ci-robot assigned sttts Sep 29, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 29, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020

bump(github.com/openshift/api): add logLevel validation

3b10b2c

dmage force-pushed the loglevel-validation branch from 9a0ea4f to 3b10b2c Compare September 29, 2020 13:35

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 29, 2020

stlaz mentioned this pull request Sep 30, 2020

Bug 1883792: move to klog/v2 and bump kube/openshift deps #354

Merged

openshift-merge-robot merged commit 28f5f6c into openshift:master Oct 2, 2020

dmage deleted the loglevel-validation branch January 10, 2023 01:17

Conversation

dmage commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

sttts commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

sttts commented Sep 29, 2020

Uh oh!

sttts commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

sttts commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Sep 30, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 2, 2020