Bug 1883689: Add validation for logLevel by dmage · Pull Request #455 · openshift/cluster-etcd-operator

dmage · 2020-09-29T10:40:02Z

openshift/api#736 added restrictions for logLevel values. This PR vendors new openshift/api to get new CRDs. Also it replaces manifests/0000_12_etcd-operator_01_config.crd.yaml with yaml from openshift/api.

openshift-ci-robot · 2020-09-29T10:40:08Z

@dmage: This pull request references Bugzilla bug 1878040, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1878040: Add validation for logLevel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2020-09-29T10:45:18Z

/lgtm
/approve

hexfusion · 2020-09-29T11:26:19Z

/hold
for openshift/api#752 plus new bump.

sttts · 2020-09-29T12:04:51Z

/hold

sttts · 2020-09-29T15:09:30Z

/lgtm
/hold cancel

openshift-ci-robot · 2020-09-29T15:09:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-29T15:18:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T15:44:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T15:57:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T17:29:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T17:41:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T18:46:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-29T20:56:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dmage · 2020-09-29T21:16:25Z

/retitle Bug 1883689: Add validation for logLevel

openshift-ci-robot · 2020-09-29T21:16:48Z

@dmage: An error was encountered adding this pull request to the external tracker bugs for bug 1883689 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/cluster-etcd-operator/pulls/455 Error: 403 Forbidden at /loader/0x5600164df528/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x5600164df528/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x5600164df528/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x560026...', 'https://api.github.com/repos/openshift/cluster-etcd-operator/...', 'GET') called at /loader/0x5600164df528/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x560026...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x560026296428)') called at /loader/0x5600164df528/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5600164df528/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x560026296428)', 1) called at /loader/0x5600164df528/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x5600262979f8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 877 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x560022dbddb0)', 'HASH(0x560022dd81e8)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x560022dd81e8)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x560022e145d0)') called at /loader/0x5600164df528/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x560024315ed8)') called at (eval 2405) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5600226e3ae8)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5600226e3ae8)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x560022d73668)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x560022ccd550)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x560022ccd550)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x560022d73668)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x560022d73668)') called at (eval 2405) line 0 eval {...} called at (eval 2405) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1883689: Add validation for logLevel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dmage · 2020-09-29T21:16:59Z

/bugzilla refresh

openshift-ci-robot · 2020-09-29T21:17:03Z

@dmage: This pull request references Bugzilla bug 1883689, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-29T22:05:13Z

@dmage: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-disruptive	`d474e28`	link	`/test e2e-disruptive`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-09-29T22:40:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-29T23:27:45Z

@dmage: All pull requests linked via external trackers have merged:

openshift/cluster-etcd-operator#455

Bugzilla bug 1883689 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1883689: Add validation for logLevel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 29, 2020

openshift-ci-robot requested review from hexfusion and retroflexer September 29, 2020 10:40

openshift-ci-robot assigned sttts Sep 29, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 29, 2020

sttts mentioned this pull request Sep 29, 2020

Bug 1878040: operator: rename etcd CRD to name from repo openshift/api#752

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020

dmage force-pushed the loglevel-validation branch from 33b91c2 to 9c47e6d Compare September 29, 2020 11:39

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020

dmage added 2 commits September 29, 2020 15:41

bump(github.com/openshift/api): add logLevel validation

7b737d2

Use CRD from openshift/api for etcds.operator.openshift.io

d474e28

dmage force-pushed the loglevel-validation branch from 9c47e6d to d474e28 Compare September 29, 2020 13:41

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 29, 2020

openshift-ci-robot changed the title ~~Bug 1878040: Add validation for logLevel~~ Bug 1883689: Add validation for logLevel Sep 29, 2020

openshift-merge-robot merged commit f832717 into openshift:master Sep 29, 2020

Conversation

dmage commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

sttts commented Sep 29, 2020

Uh oh!

hexfusion commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sttts commented Sep 29, 2020

Uh oh!

sttts commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

dmage commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

dmage commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hexfusion commented Sep 29, 2020 •

edited

Loading

openshift-ci-robot commented Sep 29, 2020 •

edited

Loading