OCPBUGS-15365: manager: filter the cache of configmaps#544
Conversation
This controller LISTs and WATCHes ConfigMaps in order to react to changes to one and only one ConfigMap - the controller's (legacy) configuration. Previously, this controller would hold the entire cluster's ConfigMaps in cache in order to do this; with this change, we will only ever watch one ConfigMap and hold it in memory. This is unfortunately a cross-cutting concern and it blurs the control flow that previously exited, but we need these options to be passed to the cache constructor at the moment we create the manager, so it's not clear that there is a factoring that keeps this from happening until the controller initialization code runs, like where we add filtering today. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
|
cc @abutcher |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abutcher, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@stevekuznetsov: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 48.80% 48.80%
=======================================
Files 88 88
Lines 9853 9853
=======================================
Hits 4809 4809
Misses 4469 4469
Partials 575 575 |
|
/retitle PORTENABLE-526: manager: filter the cache of configmaps |
stevekuznetsov
changed the title
|
/cherry-pick release-4.13 |
|
/cherry-pick release-4.12 |
|
/cherry-pick release-4.11 |
|
@stevekuznetsov: new pull request created: #551 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stevekuznetsov: new pull request created: #552 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stevekuznetsov: new pull request created: #553 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stevekuznetsov
changed the title
stevekuznetsov
changed the title
|
@stevekuznetsov: Jira Issue OCPBUGS-15365: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-15365 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@stevekuznetsov: Jira Issue OCPBUGS-15365 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
|
@stevekuznetsov: Jira Issue OCPBUGS-15365: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-15365 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…configmap-cache manager: filter the cache of configmaps
6 participants
This controller LISTs and WATCHes ConfigMaps in order to react to changes to one and only one ConfigMap - the controller's (legacy) configuration. Previously, this controller would hold the entire cluster's ConfigMaps in cache in order to do this; with this change, we will only ever watch one ConfigMap and hold it in memory. This is unfortunately a cross-cutting concern and it blurs the control flow that previously exited, but we need these options to be passed to the cache constructor at the moment we create the manager, so it's not clear that there is a factoring that keeps this from happening until the controller initialization code runs, like where we add filtering today.