[release-4.12] PORTENABLE-526: manager: filter the cache of configmaps#552
Conversation
This controller LISTs and WATCHes ConfigMaps in order to react to changes to one and only one ConfigMap - the controller's (legacy) configuration. Previously, this controller would hold the entire cluster's ConfigMaps in cache in order to do this; with this change, we will only ever watch one ConfigMap and hold it in memory. This is unfortunately a cross-cutting concern and it blurs the control flow that previously exited, but we need these options to be passed to the cache constructor at the moment we create the manager, so it's not clear that there is a factoring that keeps this from happening until the controller initialization code runs, like where we add filtering today. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
|
@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug PORTENABLE-526 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"customfield_12318341":"Operation value must be a string"}}
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-4.12 #552 +/- ##
================================================
- Coverage 46.62% 46.58% -0.04%
================================================
Files 94 94
Lines 10053 10061 +8
================================================
Hits 4687 4687
- Misses 4807 4815 +8
Partials 559 559
|
|
/close |
|
@stevekuznetsov: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
This is an automated cherry-pick of #544
/assign stevekuznetsov