Skip to content

OCPBUGS-14368: Default to kube-proxy health probes for Service type=LoadBalancer#72

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
damdo:etp-cluster-services-default-kubeproxy-probes-downstream
Jun 7, 2023
Merged

OCPBUGS-14368: Default to kube-proxy health probes for Service type=LoadBalancer#72
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
damdo:etp-cluster-services-default-kubeproxy-probes-downstream

Conversation

@damdo
Copy link
Copy Markdown
Member

@damdo damdo commented Jun 7, 2023

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 7, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@damdo: This pull request references Jira Issue OCPBUGS-14368, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 7, 2023
@openshift-ci openshift-ci Bot requested a review from sunzhaohua2 June 7, 2023 07:52
@openshift-ci openshift-ci Bot requested review from JoelSpeed and odvarkadaniel June 7, 2023 07:53
@JoelSpeed
Copy link
Copy Markdown

Commit message prefix UPSTREAM: <carry>: should refer to the upstream PR, can you please update to UPSTREAM: 3887:

Otherwise I think this is ok.

Having reviewed what's going on here, and based on my comments upstream, I think this is safe to proceed with, I don't think this will break existing users

@damdo
Copy link
Copy Markdown
Member Author

damdo commented Jun 7, 2023

Ah yes, good point! Commit message updated.
Thanks @JoelSpeed

@JoelSpeed
Copy link
Copy Markdown

Ok, changes LGTM but I'd like to see how the techpreview jobs handle this, in particular a techpreview upgrade would be good to observe passing

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 7, 2023

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Copy Markdown

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit ce02abc into openshift:master Jun 7, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@damdo: Jira Issue OCPBUGS-14368: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14368 has been moved to the MODIFIED state.

Details

In response to this:

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants