OCPBUGS-14368: Do not detach masters from LB when unready

[damdo]

Originally the masters that would go UnReady were detached from the LoadBalancer to avoid traffic being forwarded to the pods backing the LoadBalancer's Service.

This would cause an issue on OCP because masters rely on being connected to this public LoadBalancer to retain outbound internet connection, and having an UnReady master detached may have rendered it unable to recover due to it not having access to outbound internet connection.

Now that kube-proxy based healthprobes have been/are being implemented for Services of type LoadBalancer and ETP=Cluster (downstream with #72 and upstream with kubernetes-sigs#3887)
the master detachment on Unreadiness is not necessary anymore.

As such we disabling this.

This is a fix for kubernetes-sigs#3500

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-14368, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Originally the masters that would go UnReady were detached from the LoadBalancer to avoid traffic being forwarded to the pods backing the LoadBalancer's Service.

This would cause an issue on OCP because masters rely on being connected to this public LoadBalancer to retain outbound internet connection, and having an UnReady master detached may have rendered it unable to recover due to it not having access to outbound internet connection.

Now that kube-proxy based healthprobes have been/are being implemented for Services of type LoadBalancer and ETP=Cluster (downstream with #72 and upstream with kubernetes-sigs#3887)
the master detachment on Unreadiness is not necessary anymore.

As such we disabling this.

This is a fix for kubernetes-sigs#3500

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-14368, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Originally the masters that would go UnReady were detached from the LoadBalancer to avoid traffic being forwarded to the pods backing the LoadBalancer's Service.

This would cause an issue on OCP because masters rely on being connected to this public LoadBalancer to retain outbound internet connection, and having an UnReady master detached may have rendered it unable to recover due to it not having access to outbound internet connection.

Now that kube-proxy based healthprobes have been/are being implemented for Services of type LoadBalancer and ETP=Cluster (downstream with #72 and upstream with kubernetes-sigs#3887)
the master detachment on Unreadiness is not necessary anymore.

As such we disabling this.

This is a fix for kubernetes-sigs#3500

TODO:

• Needs upstream PR
• Needs commit rename to point to the upsream PR <UPSTREAM> ...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

I'd like to carry this PR without submitting it upstream. In openshift we need to make sure to improve the topology by including an improved topology for the azure load balancers, introducing a secondary load balancer backend pool for outbound traffic

[openshift-ci-robot]

@damdo: This pull request references Jira Issue OCPBUGS-14368, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Originally the masters that would go UnReady were detached from the LoadBalancer to avoid traffic being forwarded to the pods backing the LoadBalancer's Service.

This would cause an issue on OCP because masters rely on being connected to this public LoadBalancer to retain outbound internet connection, and having an UnReady master detached may have rendered it unable to recover due to it not having access to outbound internet connection.

Now that kube-proxy based healthprobes have been/are being implemented for Services of type LoadBalancer and ETP=Cluster (downstream with #72 and upstream with kubernetes-sigs#3887)
the master detachment on Unreadiness is not necessary anymore.

As such we disabling this.

This is a fix for kubernetes-sigs#3500

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[damdo]

/test e2e-azure-ovn

[damdo]

/hold
For QE pre-merge testing.

[damdo]

/assign @JoelSpeed

[damdo]

/retest

[openshift-ci]

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[JoelSpeed]

/approve
/lgtm
/hold

I'd like QE approval that this, in combination with the promotion PR to GA, openshift/cluster-config-operator#307, solves the image pull issue they've been observing, before we merge

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

/jira refresh

I've been manually testing this and am confident it's doing what I'm expecting it to do

[openshift-ci-robot]

@JoelSpeed: This pull request references Jira Issue OCPBUGS-14368, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

I've been manually testing this and am confident it's doing what I'm expecting it to do

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

/hold cancel

[openshift-ci-robot]

@damdo: Jira Issue OCPBUGS-14368: All pull requests linked via external trackers have merged:

• openshift/cloud-provider-azure#72
• openshift/cloud-provider-azure#76

Jira Issue OCPBUGS-14368 has been moved to the MODIFIED state.

Details

In response to this:

Originally the masters that would go UnReady were detached from the LoadBalancer to avoid traffic being forwarded to the pods backing the LoadBalancer's Service.

This would cause an issue on OCP because masters rely on being connected to this public LoadBalancer to retain outbound internet connection, and having an UnReady master detached may have rendered it unable to recover due to it not having access to outbound internet connection.

Now that kube-proxy based healthprobes have been/are being implemented for Services of type LoadBalancer and ETP=Cluster (downstream with #72 and upstream with kubernetes-sigs#3887)
the master detachment on Unreadiness is not necessary anymore.

As such we disabling this.

This is a fix for kubernetes-sigs#3500

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.