Skip to content

Bump base images to ocp v4.8 and Go to v1.15#149

Closed
pierreprinetti wants to merge 1 commit intoopenshift:masterfrom
shiftstack:bump_golang
Closed

Bump base images to ocp v4.8 and Go to v1.15#149
pierreprinetti wants to merge 1 commit intoopenshift:masterfrom
shiftstack:bump_golang

Conversation

@pierreprinetti
Copy link
Copy Markdown

@pierreprinetti pierreprinetti commented Jan 8, 2021

/hold until master is open

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 8, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pierreprinetti after the PR has been reviewed.
You can assign the PR to them by writing /assign @pierreprinetti in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mandre
mandre reviewed Jan 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

mandre
mandre reviewed Jan 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 11, 2021

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-openstack 21eb12e link /test e2e-openstack
ci/prow/images 21eb12e link /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Copy Markdown
Author

pierreprinetti commented Jan 13, 2021

Superseded by #151

/close

@pierreprinetti pierreprinetti deleted the bump_golang branch January 13, 2021 21:17
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 13, 2021

@pierreprinetti: Closed this PR.

Details

In response to this:

Superseded by #151

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@syjabri @pierreprinetti
Disable ufw on ubuntu openshift#149 (openshift#165)
8758c27 
* Disable ufw on ubuntu openshift#149

* Rename systemd drop-in to add priority

* Remove comment

* Add EnvironmentFile directive to docker drop-in

* Source DOCKER_OPTS in the ExecStart directive

* Add line to separate file create and commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@iamemilio iamemilio Awaiting requested review from iamemilio

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@mandre mandre

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierreprinetti @openshift-ci-robot @mandre