Skip to content

Bug 1915926: Update ose-openstack-machine-controllers builder & base …#151

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:bz-1915926
Jan 14, 2021
Merged

Bug 1915926: Update ose-openstack-machine-controllers builder & base …#151
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:bz-1915926

Conversation

@pierreprinetti
Copy link
Copy Markdown

@pierreprinetti pierreprinetti commented Jan 13, 2021

…images to be consistent with ART

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 13, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 13, 2021

@pierreprinetti: This pull request references Bugzilla bug 1915926, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1915926: Update ose-openstack-machine-controllers builder & base …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mandre
mandre reviewed Jan 13, 2021
View reviewed changes
Comment thread Dockerfile Outdated
@pierreprinetti pierreprinetti mentioned this pull request Jan 13, 2021
Closed
@pierreprinetti pierreprinetti mentioned this pull request Jan 13, 2021
Closed
mandre
mandre reviewed Jan 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit e9a2d1f into openshift:master Jan 14, 2021
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 14, 2021

@pierreprinetti: All pull requests linked via external trackers have merged:

Bugzilla bug 1915926 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1915926: Update ose-openstack-machine-controllers builder & base …

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the bz-1915926 branch January 14, 2021 07:23
@pierreprinetti pierreprinetti mentioned this pull request Jan 14, 2021
Closed
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@jichenjc @pierreprinetti
Add boot from volume support (openshift#151)
d3d4ddf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@adduarte adduarte Awaiting requested review from adduarte

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierreprinetti @openshift-ci-robot @mandre @openshift-merge-robot