starts to manage the encryption configuration#379
Merged
openshift-merge-robot merged 7 commits intoopenshift:masterfrom Dec 3, 2020
Merged
starts to manage the encryption configuration#379openshift-merge-robot merged 7 commits intoopenshift:masterfrom
openshift-merge-robot merged 7 commits intoopenshift:masterfrom
Conversation
Contributor
Author
|
/hold for manual tests. |
openshift-ci-robot
added
the
do-not-merge/hold
sttts
reviewed
Nov 23, 2020
| // case 1 encryption off or the secret was annotated - return an empty list of EncryptedGRs | ||
| // case 2 otherwise return the authoritative list of EncryptedGRs | ||
| // case 1 encryption off or the secret wasn't annotated - return the authoritative list of EncryptedGRs | ||
| // case 2 otherwise return an empty list of EncryptedGRs - OAS-O is still in charge |
Contributor
There was a problem hiding this comment.
please be explicit here: what does "otherwise" actually mean?
sttts
reviewed
Nov 23, 2020
| // - we suppress the error so that the encryption controllers: | ||
| // 1. don't report Degraded when encryption is off | ||
| // 2. don't requeue when encryption is off | ||
| return false, nil // case 1 - OAS-O in charge |
Contributor
There was a problem hiding this comment.
see first line of the comment does not match. Probably the whole block of comment needs an update.
p0lyn0mial
changed the title
p0lyn0mial
force-pushed
the
cao-manages-encryption-cfg
branch
2 times, most recently
from
bc8148f to
a67b790
Compare
p0lyn0mial
commented
Nov 25, 2020
p0lyn0mial
force-pushed
the
cao-manages-encryption-cfg
branch
from
a67b790 to
6fa6e1d
Compare
p0lyn0mial
force-pushed
the
cao-manages-encryption-cfg
branch
2 times, most recently
from
cc357ce to
4e77da6
Compare
Contributor
|
/lgtm |
openshift-ci-robot
added
lgtm
p0lyn0mial
force-pushed
the
cao-manages-encryption-cfg
branch
from
5b874b3 to
8827c4f
Compare
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
1 similar comment
Contributor
|
/retest |
Contributor
Author
|
|
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates the encryption provider so that CAO can start to manage its own encryption configuration.