Skip to content

Temporary disable tests broken upstream#25732

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ingvagabund:disable-sig-apps-due-to-missing-image
Dec 3, 2020
Merged

Temporary disable tests broken upstream#25732
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
ingvagabund:disable-sig-apps-due-to-missing-image

Conversation

@ingvagabund
Copy link
Copy Markdown
Member

@ingvagabund ingvagabund commented Dec 2, 2020

Namely:

  • [sig-apps] ReplicationController should serve a basic image on each replica with a private image
  • [sig-apps] ReplicaSet should serve a basic image on each replica with a private image

See kubernetes/kubernetes#97002

BZ reminding us to re-enable the tests again: https://bugzilla.redhat.com/show_bug.cgi?id=1903674

Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Dec 2, 2020

/retest

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Dec 2, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2020
@ingvagabund
Copy link
Copy Markdown
Member Author

/retest

@ingvagabund
Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2020
@ingvagabund
Copy link
Copy Markdown
Member Author

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants