Bug 1903206: Check Ready condition status in Endpointslices by frobware · Pull Request #229 · openshift/router

frobware · 2020-12-02T12:14:16Z

When aggregating endpointslices check the Ready condition status. If
it is not ready then accumulate those addresses into the
NotReadyAddresses bucket. Although the router doesn't actually
use NotReadyAddresses we set this to have a faithful and technically
correct translation of EndpointSlices to Endpoints.

EndpointSlices were introduced in 4.6: see #154

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1903206

openshift-ci-robot · 2020-12-02T12:14:24Z

@frobware: This pull request references Bugzilla bug 1903206, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1903206: Check Ready condition status in Endpointslices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

When aggregating endpointslices check the Ready condition status. If it is not ready then accumulate those addresses into the NotReadyAddresses bucket. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1903206

frobware · 2020-12-02T12:38:44Z

/cherry-pick 4.6

openshift-cherrypick-robot · 2020-12-02T12:38:44Z

@frobware: once the present PR merges, I will cherry-pick it on top of 4.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware · 2020-12-02T14:11:20Z

[sig-apps] ReplicaSet should serve a basic image on each replica with a private image [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-apps] ReplicationController should serve a basic image on each replica with a private image [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-network] pods should successfully create sandboxes by getting pod
[sig-network] pods should successfully create sandboxes by reading container

/retest

openshift-ci-robot · 2020-12-02T14:18:50Z

@frobware: This pull request references Bugzilla bug 1903206, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1903206: Check Ready condition status in Endpointslices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware · 2020-12-02T16:57:19Z

73 unit test failures.

/test e2e-agnostic

openshift-ci-robot · 2020-12-02T17:14:40Z

@frobware: This pull request references Bugzilla bug 1903206, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1903206: Check Ready condition status in Endpointslices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2020-12-02T17:48:59Z

/lgtm

openshift-ci-robot · 2020-12-02T17:49:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah,frobware]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

frobware · 2020-12-02T19:02:43Z

/retest

frobware · 2020-12-02T20:16:00Z

 Using must-gather plug-in image: registry.redhat.io/openshift4/ose-must-gather:latest
Unable to connect to the server: dial tcp 35.237.165.255:6443: i/o timeout

/retest

frobware · 2020-12-02T23:26:04Z

[sig-apps] ReplicationController should serve a basic image on each replica with a private image [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-apps] ReplicaSet should serve a basic image on each replica with a private image [Suite:openshift/conformance/parallel] [Suite:k8s]

/retest

frobware · 2020-12-03T09:20:08Z

[sig-apps] ReplicaSet should serve a basic image on each replica with a private image [Suite:openshift/conformance/parallel] [Suite:k8s]: [sig-apps] ReplicaSet should serve a basic image on each replica with a private image [Suite:openshift/conformance/parallel] [Suite:k8s] 
[sig-apps] ReplicationController should serve a basic image on each replica with a private image [Suite:openshift/conformance/parallel] [Suite:k8s] 
[sig-network] pods should successfully create sandboxes by writing network status 	0s
[sig-network] pods should successfully create sandboxes by getting pod 	0s
[sig-network] pods should successfully create sandboxes by reading container 	0s

/retest

frobware · 2020-12-03T09:28:44Z

Test failures:

[sig-apps] ReplicationController should serve a basic image on each replica with a private image [Suite:openshift/conformance/parallel] [Suite:k8s] 
[sig-apps] ReplicaSet should serve a basic image on each replica with a private image

Replica* failures is this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1903674
And there's a PR to disable the test: Temporary disable tests broken upstream origin#25732

frobware · 2020-12-03T09:34:26Z

Re:

[sig-network] pods should successfully create sandboxes by writing network status 	0s
[sig-network] pods should successfully create sandboxes by getting pod 	0s
[sig-network] pods should successfully create sandboxes by reading container

The pod unit test failures look like they are covered by this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1882750#c29

openshift-ci-robot · 2020-12-03T11:19:48Z

@frobware: All pull requests linked via external trackers have merged:

openshift/router#229

Bugzilla bug 1903206 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1903206: Check Ready condition status in Endpointslices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-12-03T11:19:59Z

@frobware: cannot checkout 4.6: error checking out 4.6: exit status 1. output: error: pathspec '4.6' did not match any file(s) known to git

Details

In response to this:

/cherry-pick 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frobware · 2020-12-03T11:27:30Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2020-12-03T11:27:37Z

@frobware: new pull request created: #230

Details

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Moved the existing utility function into endpointsubset package. Added unit tests to assert on EndpointSlices having Ready/NotReady conditions. Follow on from openshift#229

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 2, 2020

openshift-ci-robot requested review from candita and ironcladlou December 2, 2020 12:14

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020

Check Ready condition status in Endpointslices

1ac9774

When aggregating endpointslices check the Ready condition status. If it is not ready then accumulate those addresses into the NotReadyAddresses bucket. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1903206

frobware force-pushed the routes-traffic-bz-1903206 branch from ca81802 to 1ac9774 Compare December 2, 2020 12:23

sgreene570 reviewed Dec 2, 2020

View reviewed changes

Comment thread pkg/router/controller/router_controller.go

Miciah reviewed Dec 2, 2020

View reviewed changes

Comment thread pkg/router/controller/router_controller.go

openshift-ci-robot assigned Miciah Dec 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020

openshift-merge-robot merged commit 7b1d754 into openshift:master Dec 3, 2020

openshift-cherrypick-robot mentioned this pull request Dec 3, 2020

[release-4.6] Bug 1904010: Check Ready condition status in Endpointslices #230

Merged

frobware mentioned this pull request Dec 3, 2020

Bug 1903206: Add unit tests to verify NotReadyAddresses in EndpointSlices #231

Merged

frobware deleted the routes-traffic-bz-1903206 branch May 1, 2024 12:04

Conversation

frobware commented Dec 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 2, 2020

Uh oh!

frobware commented Dec 2, 2020

Uh oh!

openshift-cherrypick-robot commented Dec 2, 2020

Uh oh!

frobware commented Dec 2, 2020

Uh oh!

openshift-ci-robot commented Dec 2, 2020

Uh oh!

Uh oh!

Uh oh!

frobware commented Dec 2, 2020

Uh oh!

openshift-ci-robot commented Dec 2, 2020

Uh oh!

Miciah commented Dec 2, 2020

Uh oh!

openshift-ci-robot commented Dec 2, 2020

Uh oh!

frobware commented Dec 2, 2020

Uh oh!

frobware commented Dec 2, 2020

Uh oh!

frobware commented Dec 2, 2020

Uh oh!

frobware commented Dec 3, 2020

Uh oh!

frobware commented Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

frobware commented Dec 3, 2020

Uh oh!

openshift-ci-robot commented Dec 3, 2020

Uh oh!

openshift-cherrypick-robot commented Dec 3, 2020

Uh oh!

frobware commented Dec 3, 2020

Uh oh!

openshift-cherrypick-robot commented Dec 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

frobware commented Dec 2, 2020 •

edited

Loading

frobware commented Dec 3, 2020 •

edited

Loading