CCM namespace should be labelled as privileged#202
Merged
Conversation
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lobziik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
/lgtm I just tested this on OpenStack. It allows CCM to start and nodes become ready. |
Contributor
|
Incidentally, OpenStack uses CCM by default so our CI is currently completely on fire. If we could merge this quickly I'd be very grateful. |
Contributor
Author
|
@mdbooth Did you review the openstack failures here? Looks like you'll need to fix the storage as well as the CCM, will get this merged soon but would like to see at least some of the CI pass/run |
Contributor
Yes I did, and they're confusing because that namespace already has the correct labels. Lets handle that separately as that's a much smaller fire. |
Contributor
Also, I just created a cluster using this PR. Although I see this error in the logs in my cluster, the pods deploy shortly thereafter 🤔 I wonder if there's a race between the namespace and deployment creation? They certainly seem to be created in order. |
Contributor
|
/retest-required |
Contributor
Author
|
/retest |
Contributor
|
appears to do no harm (some passes) and this has a good chance of unwedging us. m erging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All techpreview jobs are currently failing because of the new pod security admission policy checks. This should resolve the issue for now