Skip to content

ci-operator/config: Enable TP features before cluster creation in o/platform-operators#31872

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
timflannagan:enable-tp-features-platform-operators
Sep 8, 2022
Merged

ci-operator/config: Enable TP features before cluster creation in o/platform-operators#31872
openshift-merge-robot merged 1 commit into
openshift:masterfrom
timflannagan:enable-tp-features-platform-operators

Conversation

@timflannagan
Copy link
Copy Markdown
Contributor

@timflannagan timflannagan commented Aug 31, 2022

Update the Makefile target from make e2e to make test-e2e.

Update the e2e prowjob to enable TP features before running the configuring Makefile target.

Signed-off-by: timflannagan timflannagan@gmail.com

@openshift-ci openshift-ci Bot requested review from exdx and tylerslaton August 31, 2022 19:15
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Sep 1, 2022

/retest

@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Sep 1, 2022

Added the requisite cluster profile annotations, so hopefully that evens out the e2e runs.

/retest

@timflannagan timflannagan force-pushed the enable-tp-features-platform-operators branch from 2203fbd to 6891350 Compare September 1, 2022 21:49
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2022
@timflannagan timflannagan force-pushed the enable-tp-features-platform-operators branch from 6891350 to 34fc2cc Compare September 1, 2022 21:51
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2022
@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Sep 2, 2022

/retest

exdx
exdx reviewed Sep 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Sep 2, 2022

Just trying to get one more rehearsal run.

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2022
@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Sep 5, 2022

Failed at:

level=error msg=Bootstrap failed to complete: timed out waiting for the condition
level=error msg=Failed to wait for bootstrapping to complete. This error usually happens when there is a problem with control plane hosts that prevents the control plane operators from creating the control plane.

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Sep 5, 2022

/retest

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Sep 5, 2022

Hi @timflannagan one question, I found we used this step https://github.com/openshift/release/blob/master/ci-operator/step-registry/ipi/conf/techpreview/ipi-conf-techpreview-commands.sh that created a file called manifest_feature_gate.yaml, but where we call that file to create the FeatureGate resource? Thanks!

@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Sep 6, 2022

Looks like we're waiting on openshift/cluster-cloud-controller-manager-operator#202 to merge before we can consume any of these TP workflows.

@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Sep 7, 2022

/retest

@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Sep 8, 2022

Looks like those tests are online now.

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2022
@exdx
Copy link
Copy Markdown
Contributor

exdx commented Sep 8, 2022

/retest

@exdx
Copy link
Copy Markdown
Contributor

exdx commented Sep 8, 2022

Do we need to manually rebase this off the fix in order to pass CI?

@timflannagan
Copy link
Copy Markdown
Contributor Author

timflannagan commented Sep 8, 2022

I don't think so given they're rehearsals (i.e. optional checks). I was more interested in getting the actual tech preview CI workflow green, and it seems like that's finally the case, vs. seeing our e2e suite pass given we're not introduced into the payload yet.

@timflannagan timflannagan force-pushed the enable-tp-features-platform-operators branch from 34fc2cc to 4edfe7b Compare September 8, 2022 14:02
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@timflannagan
ci-operator/config: Enable TP features before cluster creation in o/p…
4edfe7b 
…latform-operators

Signed-off-by: timflannagan <timflannagan@gmail.com>
@tylerslaton
Copy link
Copy Markdown

tylerslaton commented Sep 8, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, timflannagan, tylerslaton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 8, 2022

@timflannagan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/platform-operators/main/e2e 2203fbdca51f007982976b5f83544dcbd6bfbdd3 link unknown /test pj-rehearse
ci/rehearse/openshift/platform-operators/release-4.12/e2e 2203fbdca51f007982976b5f83544dcbd6bfbdd3 link unknown /test pj-rehearse
ci/rehearse/openshift/platform-operators/release-4.13/e2e 2203fbdca51f007982976b5f83544dcbd6bfbdd3 link unknown /test pj-rehearse
ci/rehearse/openshift/platform-operators/release-4.13/e2e-techpreview 4edfe7b link unknown /test pj-rehearse
ci/rehearse/openshift/platform-operators/main/e2e-techpreview 4edfe7b link unknown /test pj-rehearse
ci/prow/pj-rehearse 4edfe7b link false /test pj-rehearse
ci/rehearse/openshift/platform-operators/release-4.12/e2e-techpreview 4edfe7b link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 703148a into openshift:master Sep 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 8, 2022

@timflannagan: Updated the following 6 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-platform-operators-main.yaml using file ci-operator/config/openshift/platform-operators/openshift-platform-operators-main.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-platform-operators-release-4.12.yaml using file ci-operator/config/openshift/platform-operators/openshift-platform-operators-release-4.12.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-platform-operators-release-4.13.yaml using file ci-operator/config/openshift/platform-operators/openshift-platform-operators-release-4.13.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-platform-operators-main-presubmits.yaml using file ci-operator/jobs/openshift/platform-operators/openshift-platform-operators-main-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-platform-operators-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/platform-operators/openshift-platform-operators-release-4.12-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-platform-operators-release-4.13-presubmits.yaml using file ci-operator/jobs/openshift/platform-operators/openshift-platform-operators-release-4.13-presubmits.yaml
Details

In response to this:

Update the Makefile target from make e2e to make test-e2e.

Update the e2e prowjob to enable TP features before running the configuring Makefile target.

Signed-off-by: timflannagan timflannagan@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan timflannagan deleted the enable-tp-features-platform-operators branch September 8, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylerslaton tylerslaton Awaiting requested review from tylerslaton

1 more reviewer

@exdx exdx exdx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@exdx exdx

@tylerslaton tylerslaton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@timflannagan @jianzhangbjz @exdx @tylerslaton @openshift-merge-robot