Ensure priorityClass is set on AWS CCM#38
Ensure priorityClass is set on AWS CCM#38openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Satisfy requirements of "[sig-arch] Managed cluster should ensure platform components have system-* priority class associated"
|
/retest |
|
/lgtm |
|
@Danil-Grigorev: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
JoelSpeed
left a comment
JoelSpeed
left a comment
There was a problem hiding this comment.
Could we add to the description why this is system-cluster-critical as opposed to the other priority classes please?
|
Openstack manifests are |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Ensure priorityClass is set on AWS CCM
4 participants
Satisfy requirements of "[sig-arch] Managed cluster should ensure platform components have system-* priority class associated"
Full log: https://console.build01.ci.openshift.org/api/kubernetes/api/v1/namespaces/ci-op-6t1wq5k4/pods/e2e-aws-ccm-openshift-e2e-test/log?container=test
Increase weight on affinity settings to ensure the two pods are not scheduled on the same Node in edge cases.
Reasoning:
https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical
OpenStack manifests have that same field. Cluster will not become healthy during install if those pods are not healthy. Not
system-node-criticalas provisioned Nodes could operate without these pods running.