Skip to content

[OCPCLOUD-1110] Test full migration workflow to CCM with CSI driver#18138

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Danil-Grigorev:kubelet-migrate-external
May 10, 2021
Merged

[OCPCLOUD-1110] Test full migration workflow to CCM with CSI driver#18138
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Danil-Grigorev:kubelet-migrate-external

Conversation

@Danil-Grigorev
Copy link
Copy Markdown

@Danil-Grigorev Danil-Grigorev commented Apr 28, 2021 •
edited
Loading

This PR reconfigures cluster to run CCM deployment and disables cloud
integration in KCM and Kubelet. It is currently achieved by overriding
MCO and KCMO images with changes allowing to set correct flags.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch 3 times, most recently from 56bf16a to b6caa8b Compare April 28, 2021 11:27
@Danil-Grigorev
Copy link
Copy Markdown
Author

Danil-Grigorev commented Apr 28, 2021

/retest

@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch 3 times, most recently from 9396ddb to 2e6f0f2 Compare April 28, 2021 12:16
@Danil-Grigorev
Copy link
Copy Markdown
Author

Danil-Grigorev commented Apr 28, 2021

/retest

@Danil-Grigorev
Copy link
Copy Markdown
Author

Danil-Grigorev commented Apr 28, 2021

/test pj-rehearse

@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch from 2e6f0f2 to 1ff5686 Compare April 28, 2021 13:01
@Danil-Grigorev Danil-Grigorev changed the title Make featureGate apply step more resilent to API server timeouts Build release image including a feature gate switch in MCO Apr 28, 2021
@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch 3 times, most recently from 8a342b5 to 12ed848 Compare April 28, 2021 16:05
elmiko
elmiko reviewed Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this generally makes sense to me, i just have a question about one of the timeouts

Comment thread ci-operator/step-registry/ccm/conf/apply-feature-gate/ccm-conf-apply-feature-gate-commands.sh Outdated
@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch 12 times, most recently from 70c5f04 to 6d0862d Compare April 29, 2021 10:17
@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch from 0cec4fc to 430d16f Compare May 5, 2021 11:17
@Danil-Grigorev Danil-Grigorev changed the title Build release image including a feature gate switch in MCO Build release image including a feature gate switch in MCO and KCMO May 5, 2021
@Danil-Grigorev
Copy link
Copy Markdown
Author

Danil-Grigorev commented May 5, 2021

/retest

@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch from 430d16f to 01410ca Compare May 6, 2021 09:37
@Danil-Grigorev Danil-Grigorev changed the title Build release image including a feature gate switch in MCO and KCMO Test full migration workflow to CCM with CSI driver May 6, 2021
JoelSpeed
JoelSpeed reviewed May 6, 2021
View reviewed changes
Comment thread ci-operator/step-registry/openshift/e2e/aws/ccm/openshift-e2e-aws-ccm-workflow.yaml Outdated
Comment thread ci-operator/step-registry/openshift/e2e/aws/ccm/openshift-e2e-aws-ccm-workflow.yaml Outdated
Comment thread ci-operator/step-registry/ccm/conf/apply-feature-gate/ccm-conf-apply-feature-gate-commands.sh Outdated
Comment thread ci-operator/step-registry/ccm/conf/apply-feature-gate/ccm-conf-apply-feature-gate-commands.sh Outdated
@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch 5 times, most recently from 403d09b to 90118c4 Compare May 6, 2021 21:38
@Danil-Grigorev
Copy link
Copy Markdown
Author

Danil-Grigorev commented May 7, 2021

/retest

@Danil-Grigorev Danil-Grigorev requested review from JoelSpeed and elmiko May 7, 2021 10:24
@Danil-Grigorev
Copy link
Copy Markdown
Author

Danil-Grigorev commented May 7, 2021

Two sequential CI runs showed a different set of errors, and the only common should be fixed with openshift/cluster-cloud-controller-manager-operator#38:

  1. https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/18138/rehearse-18138-pull-ci-openshift-cluster-cloud-controller-manager-operator-release-4.9-e2e-aws-ccm/1390420997500309504
  2. https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/18138/rehearse-18138-pull-ci-openshift-cluster-cloud-controller-manager-operator-release-4.9-e2e-aws-ccm/1390578113125027840

/retest

hope to see it green at last.

@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch 2 times, most recently from dd18a09 to a5419ee Compare May 7, 2021 12:25
Add full migration workflow to CCM with CSI driver
eed58c1 
This PR reconfigures cluster to run CCM deployment and disables cloud
integration in KCM and Kubelet. It is currently achieved by overriding
MCO and KCMO images with changes allowing to set correct flags.

- Add MCO image override (changes from
  openshift/machine-config-operator#2386)
- Step waits for kubelet update on machines
- Add KCMO image override to test KCM migration to out-of-tree CCM
  (revendor with changes from
openshift/library-go#895)
- Make featureGate apply step more resilent to API server timeouts
@Danil-Grigorev Danil-Grigorev force-pushed the kubelet-migrate-external branch from a5419ee to eed58c1 Compare May 7, 2021 13:42
@Danil-Grigorev
Copy link
Copy Markdown
Author

Danil-Grigorev commented May 7, 2021

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2021 •
edited
Loading

@Danil-Grigorev: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-aws-ccm 12ed848c2cf6eaaa980e8d5f909743fd120b4b9a link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Danil-Grigorev
Copy link
Copy Markdown
Author

Danil-Grigorev commented May 7, 2021

/retest

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented May 10, 2021

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit fafc088 into openshift:master May 10, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 10, 2021

@Danil-Grigorev: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key ccm-conf-apply-feature-gate-commands.sh using file ci-operator/step-registry/ccm/conf/apply-feature-gate/ccm-conf-apply-feature-gate-commands.sh
  • key ccm-conf-apply-feature-gate-ref.yaml using file ci-operator/step-registry/ccm/conf/apply-feature-gate/ccm-conf-apply-feature-gate-ref.yaml
  • key openshift-e2e-aws-ccm-workflow.yaml using file ci-operator/step-registry/openshift/e2e/aws/ccm/openshift-e2e-aws-ccm-workflow.yaml
Details

In response to this:

This PR reconfigures cluster to run CCM deployment and disables cloud
integration in KCM and Kubelet. It is currently achieved by overriding
MCO and KCMO images with changes allowing to set correct flags.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Danil-Grigorev Danil-Grigorev mentioned this pull request May 17, 2021
Closed
@Danil-Grigorev Danil-Grigorev changed the title Test full migration workflow to CCM with CSI driver [OCPCLOUD-1110] Test full migration workflow to CCM with CSI driver Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@elmiko elmiko Awaiting requested review from elmiko

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Danil-Grigorev @openshift-ci-robot @JoelSpeed @elmiko @openshift-merge-robot