[OCPCLOUD-1162] Implement bootstrap aws

[Danil-Grigorev]

Following Pod will serve Node initialization during cluster bootstrap in AWS.

• Running only --controllers=cloud-node as cloud-node controller contains node initialization parts we require in bootstrap.

apiVersion: v1
kind: Pod
metadata:
  name: aws-cloud-controller-manager
  namespace: kube-system
spec:
  priorityClassName: system-cluster-critical
  containers:
  - args:
    - --cloud-provider=aws
    - --use-service-account-credentials=false
    - --controllers=cloud-node # run only cloud-node controller required to bootstrap master nodes
    - --kubeconfig=/etc/kubernetes/secrets/kubeconfig
    - --leader-elect=false
    - -v=2
    image: gcr.io/k8s-staging-provider-aws/cloud-controller-manager:v1.19.0-alpha.1
    imagePullPolicy: IfNotPresent
    name: cloud-controller-manager
    volumeMounts:
    - mountPath: /etc/kubernetes/secrets
      name: secrets
      readOnly: true
  hostNetwork: true
  volumes:
  - hostPath:
      path: /etc/kubernetes/bootstrap-secrets
    name: secrets

[Danil-Grigorev]

/retest

[lobziik]

Overall approach make sense to me, but Pod resource is quite questionable ATM...

[Danil-Grigorev]

Unfortunately the approach to store logs on bootstrap machine does not work. Neither this, nor --log-file option works in the CCM. I assume --log-file is an issue in cloud-provider. I would leave this line in, but we would need to address this issue to simplify CCM debug in bootstrap node. cc @JoelSpeed @lobziik

[lobziik]

/lgtm

[elmiko]

this generally makes sense to me, i just have a couple questions

[elmiko]

should we have an entry for azure stack hub as well?

[Danil-Grigorev]

There is no platform for Azure Stack Hub :( We will have to implement additional logic to separate Azure and Azure Stack Hub similar to https://issues.redhat.com/browse/OCPCLOUD-1187 (well, starting from that, and then read the full infra status in operator as well to get it right).

[elmiko]

ack, thanks!

[lobziik]

/lgtm

[elmiko]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Danil-Grigorev: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-ccm	5dee6c6	link	/test e2e-aws-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.