Run CCCMO and CCM components before CNI#76
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Jul 5, 2021
Merged
Run CCCMO and CCM components before CNI#76openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci
Bot
added
the
needs-rebase
As CNI relies on CMM to initialist the Node IP addresses. We must ensure that CCCMO can set up and reconfigure if necesssary the CCM pods before the CNO has been deployed and before the CNI initialises the Node. To achieve this, we must tolerate the not-ready taint, use host networking and use the internal API Load Balancer instead of the API Service.
openshift-ci
Bot
removed
the
needs-rebase
Contributor
|
@JoelSpeed: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fedosin
approved these changes
Jul 5, 2021
Contributor
Fedosin
left a comment
Fedosin
left a comment
There was a problem hiding this comment.
@JoelSpeed Great PR! Thank you for doing this
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Fedosin
added a commit
to Fedosin/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jul 8, 2021
With openshift#76 we don't need to render static pod manifests on the bootstrap machine. So, "render" binary and all related code can be removed from the operator.
Fedosin
added a commit
to Fedosin/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jul 8, 2021
With openshift#76 we don't need to render static pod manifests on the bootstrap machine. So, "render" binary and all related code can be removed from the operator.
Merged
Fedosin
added a commit
to Fedosin/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jul 9, 2021
With openshift#76 we don't need to render static pod manifests on the bootstrap machine. So, "render" binary and all related code can be removed from the operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As CNI relies on CMM to initialist the Node IP addresses. We must ensure that CCCMO can set up and reconfigure if necesssary the CCM pods before the CNO has been deployed and before the CNI initialises the Node.
To achieve this, we must tolerate the not-ready taint, use host networking and use the internal API Load Balancer instead of the API Service.
Full motivation for why we need to do this can be found in this doc (RH Internal) https://docs.google.com/document/d/1yAczhHNJ4rDqVFFvyi7AZ27DEQdvx8DmLNbavIjrjn0/edit?ts=60de093f