Skip to content

Use /etc/openstack to mount the config and secrets#80

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Fedosin:etc_openstack
Jul 6, 2021
Merged

Use /etc/openstack to mount the config and secrets#80
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Fedosin:etc_openstack

Conversation

@Fedosin
Copy link
Copy Markdown
Contributor

@Fedosin Fedosin commented Jul 5, 2021

After #76 /etc/kubernetes is a read-only fs, so we can't create folders there.

  Normal   Pulled     0s (x3 over 24s)  kubelet            Container image "quay.io/openshift/origin-openstack-cloud-controller-manager:4.9" already present on machine
  Warning  Failed     0s                kubelet            Error: container create failed: time="2021-07-05T13:36:15Z" level=error msg="container_linux.go:367: starting container process caused: process_linux.go:495: container init caused: rootfs_linux.go:76: mounting \"/var/lib/kubelet/pods/7b2ade72-eb8b-49be-8f33-ce8a9c43d7b3/volumes/kubernetes.io~secret/secret-occm\" to rootfs at \"/etc/kubernetes/secret\" caused: mkdir /var/lib/containers/storage/overlay/5f06245b3bfd93c0c9b446484b6a918d80e1e63fa06b6e8339f157ddf41e5357/merged/etc/kubernetes/secret: read-only file system"

To avoid this, we will mount openstack related resources to /etc/openstack.

Additionally this PR fixes OpenStack CCM binary path in the deployment. According to https://github.com/openshift/cloud-provider-openstack/blob/master/images/cloud-controller-manager/Dockerfile#L10 it is /usr/bin/openstack-cloud-controller-manager and not /bin/openstack-cloud-controller-manager.

/etc/kubernetes is a read-only fs, so we can't create folders there.

To avoid this, we will mount openstack related resources to
/etc/openstack.
@openshift-ci openshift-ci Bot requested review from JoelSpeed and mandre July 5, 2021 14:03
Copy link
Copy Markdown
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

Copy link
Copy Markdown
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I assume this has been manually tested already?

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@Fedosin
Copy link
Copy Markdown
Contributor Author

Fedosin commented Jul 5, 2021

yes, with this PR I don't see this issue anymore

@Fedosin
Copy link
Copy Markdown
Contributor Author

Fedosin commented Jul 6, 2021

/test e2e-aws-upgrade

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@Fedosin
Copy link
Copy Markdown
Contributor Author

Fedosin commented Jul 6, 2021

/test e2e-aws-upgrade

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@Fedosin
Copy link
Copy Markdown
Contributor Author

Fedosin commented Jul 6, 2021

/test e2e-aws-upgrade

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 6, 2021

@Fedosin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-ccm 95318db link /test e2e-aws-ccm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 40dd06b into openshift:master Jul 6, 2021
@Fedosin Fedosin deleted the etc_openstack branch September 14, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants