Skip to content

bug 1801397: pkg/operator/guardbudget: delete MCO deployment#157

Merged
openshift-merge-robot merged 23 commits intoopenshift:masterfrom
hexfusion:remove-guard-deployment
Feb 18, 2020
Merged

bug 1801397: pkg/operator/guardbudget: delete MCO deployment#157
openshift-merge-robot merged 23 commits intoopenshift:masterfrom
hexfusion:remove-guard-deployment

Conversation

@hexfusion
Copy link
Copy Markdown
Contributor

@hexfusion hexfusion commented Feb 17, 2020

No description provided.

deads2k and others added 18 commits February 17, 2020 07:12
@deads2k
bump
8a38016
@deads2k
remove old controller loops and daemonsets
e3a5302
@deads2k
add new cluster member controller
9b260ac
@deads2k
start static pod manager
a72c1cc
@deads2k
use etcd client in clustermember controller
f37a38e
@deads2k
be sure to exclude spurious members
33e1971
@deads2k
add heavy logging for bootstrap teardown
a0d0817
@deads2k
prevent wiring etcd without a complete get of env vars
86ad32c
@deads2k
fix peer url add
8a85499
@alaypatel07 @deads2k
*: add controller to report etcd members status conditions
cc47c2b
@deads2k
try to fix the looping
519634e
@deads2k
wait for cluster-bootstrap to finish before removing bootstrap etcd
09588b8
@hexfusion @deads2k
*: add openshift-etcd quorum-guard
a7c21b0 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@sanchezl @deads2k
remove useless sort
47f9834 
  cannot control final sort order of endpoint address slice
@sanchezl @deads2k
host-etcd endpoints must exist before continuing
02d4707 
  if this controller creates host-etcd endpoints first, mco will
  not create its version which includes etcd-bootstrap.
@hexfusion @deads2k
pod.yaml: update peer ca for metrics
ea8b5c5 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
user proper certs in metrics container
9a3df2f 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
guardbudget: fix condition name
0535041
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 17, 2020
@hexfusion
remove deployment
5ea8595 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020
@hexfusion
add deployments to rbac
f1aacfe 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020

/test all

@hexfusion hexfusion closed this Feb 18, 2020
@hexfusion hexfusion reopened this Feb 18, 2020
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020

/test all

@hexfusion hexfusion force-pushed the remove-guard-deployment branch from 5b74617 to 99bd311 Compare February 18, 2020 01:43
@hexfusion hexfusion force-pushed the remove-guard-deployment branch from 99bd311 to eb18318 Compare February 18, 2020 03:06
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020

/test e2e-aws

@hexfusion
be more explicit with scaling
083df97 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
delete quorum-gaurd deployment
dafa6dc 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion hexfusion changed the title [wip] Remove guard deployment pkg/operator/guardbudget: delete MCO deployment Feb 18, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2020
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020

aws greens! running it again

/test e2e-aws

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020 •
edited
Loading

gcp fail

level=error msg="Cluster operator openshift-apiserver Degraded is True with APIServerDaemonSet_UnavailablePod: APIServerDaemonSetDegraded: 1 of 3 requested instances are unavailable"

/test e2e-gcp

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020

retesting was green
/test e2e-gcp-upgrade

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020

azure greens! 😱

/test e2e-azure

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020 •
edited
Loading

green retest

/test e2e-aws
/test e2e-gcp
/test e2e-gcp-upgrade

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020

/retest

@hexfusion hexfusion changed the title pkg/operator/guardbudget: delete MCO deployment bug 1801397: pkg/operator/guardbudget: delete MCO deployment Feb 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 18, 2020

@hexfusion: This pull request references Bugzilla bug 1801397, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

bug 1801397: pkg/operator/guardbudget: delete MCO deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 18, 2020
@hexfusion hexfusion mentioned this pull request Feb 18, 2020
Closed
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020 •
edited
Loading

Feb 18 12:03:12.718 W ns/openshift-machine-config-operator pod/etcd-quorum-guard-5b759c8dd-t4mpt Unable to attach or mount volumes: unmounted volumes=[kubecerts default-token-5vttd], unattached volumes=[kubecerts default-token-5vttd]: timed out waiting for the condition

/test e2e-gcp

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Feb 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Feb 18, 2020

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Feb 18, 2020

/skip

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Feb 18, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 18, 2020 •
edited
Loading

@hexfusion: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure dafa6dc link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Feb 18, 2020

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k deads2k mentioned this pull request Feb 18, 2020
Merged
@openshift-merge-robot openshift-merge-robot merged commit fae4277 into openshift:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alaypatel07 alaypatel07 Awaiting requested review from alaypatel07

@sttts sttts Awaiting requested review from sttts

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hexfusion @openshift-ci-robot @deads2k @openshift-bot @openshift-merge-robot @alaypatel07 @sanchezl