Skip to content

bug 1801397: Make existing pdb work#162

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:make-existing-pdb-work
Feb 19, 2020
Merged

bug 1801397: Make existing pdb work#162
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:make-existing-pdb-work

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Feb 18, 2020 •
edited
Loading

builds on #157 with a goal of making the existing PDBs functional by copying the content "first" in the listing

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 18, 2020
@deads2k deads2k mentioned this pull request Feb 18, 2020
Merged
@deads2k deads2k changed the title [wip] Make existing pdb work bug bug 1801397: Make existing pdb work Feb 18, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 18, 2020

@deads2k: This pull request references Bugzilla bug 1801397, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

bug bug 1801397: Make existing pdb work

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 18, 2020
@deads2k deads2k changed the title bug bug 1801397: Make existing pdb work bug 1801397: Make existing pdb work Feb 18, 2020
@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Feb 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
hexfusion
hexfusion reviewed Feb 18, 2020
View reviewed changes
Comment thread bindata/etcd/pod.yaml
set -euo pipefail

cp /etc/kubernetes/static-pod-resources/secrets/etcd-all-peer/etcd-peer-NODE_NAME.crt /etc/kubernetes/etcd-backup-dir/system:etcd-peer-NODE_NAME.crt
cp /etc/kubernetes/static-pod-resources/secrets/etcd-all-peer/etcd-peer-NODE_NAME.key /etc/kubernetes/etcd-backup-dir/system:etcd-peer-NODE_NAME.key
Copy link
Copy Markdown
Contributor

@hexfusion hexfusion Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR the CA needed for quorum-guard is still on disk in static-pod-resources/etcd-member/ca.crt if anyone was concerned we don't see a CA being copied.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Feb 18, 2020

message: 'Failed to create pod sandbox: rpc error: code = Unknown desc = error reserving
pod name k8s_apiserver-2vvft_openshift-apiserver_8017545a-12fd-473d-8106-061bc789273f_0
for id cd5c6debe69a2f1fd934a6f3c64231dea390d515b36c0aa730666edb3cea4cf3: name
is reserved'
metadata:

/retest

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-etcd-operator/162/pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp/565

ericavonb
ericavonb reviewed Feb 18, 2020
View reviewed changes
Comment thread pkg/operator/bootstrapteardown/bootstrap_teardown_controller.go
ericavonb
ericavonb reviewed Feb 18, 2020
View reviewed changes
Comment thread pkg/operator/bootstrapteardown/bootstrap_teardown_controller.go
@deads2k deads2k force-pushed the make-existing-pdb-work branch from e6a6458 to 0e95d6f Compare February 18, 2020 18:39
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 18, 2020
@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Feb 18, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Feb 18, 2020

/retest

1 similar comment
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Feb 19, 2020

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 719ec5c into openshift:master Feb 19, 2020
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Feb 19, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 19, 2020
Merged
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Feb 19, 2020

@deads2k: new pull request created: #169

Details

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alaypatel07 alaypatel07 Awaiting requested review from alaypatel07

2 more reviewers

@hexfusion hexfusion hexfusion left review comments

@ericavonb ericavonb ericavonb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hexfusion hexfusion

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@deads2k @openshift-ci-robot @hexfusion @openshift-bot @openshift-cherrypick-robot @ericavonb @openshift-merge-robot