[release-4.14] OCPBUGS-18728: Kuryr: Set MTU on Bootstrap, not Render phase#1995
Conversation
Since openshift#1952 `network.Render` is no longer supplied with operConfig used later, but a copy of it. This means that MTU set by Kuryr's render phase won't be used for setting the Network.Status and will lead to panic. We have this issue because for Kuryr default MTU is detected on bootstrap phase and there's no fixed value. This commit solves this by making "0" a default value for Kuryr's MTU. Having 0 means that Kuryr will attempt to autodetect the MTU. Moreover the MTU on KuryrConfig will now be set on bootstrap phase, so update of the OperConfig done after the bootstrap phase will make sure to update it too.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-18517 has been cloned as Jira Issue OCPBUGS-18728. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-18728, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/lgtm |
|
/test e2e-openstack-kuryr Let's see the installation succeeding here and merge this. |
|
/retest required |
|
@dulek: The
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/label backport-risk-assessed |
openshift-ci
Bot
added
the
backport-risk-assessed
openshift-ci
Bot
assigned
anuragthehatter,
asood-rh,
eurijon,
huiran0826,
jechen0648,
mffiedler,
qiowang721 and
rbbratta
|
The installation with Kuryr is passing, but the Kuryr jobs still fails the tests and we link this with upgrade of our testing cloud to OSP 17.1. This is however good to be merged. |
|
@eurijon, can you take a look and label with |
|
I created a bug to track the e2e tests failures https://issues.redhat.com/browse/OCPBUGS-18818 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, MaysaMacedo, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@eurijon: Could you do the honors and add |
|
/label cherry-pick-approved I'm testing the fix in 4.15 now, so this PR can be merged |
openshift-ci
Bot
added
the
cherry-pick-approved
|
Successfully verified on 4.15 |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-18728: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18728 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929 |
14 participants
This is an automated cherry-pick of #1988
/assign dulek