OCPBUGS-18517: Kuryr: Set MTU on Bootstrap, not Render phase#1988
OCPBUGS-18517: Kuryr: Set MTU on Bootstrap, not Render phase#1988openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
|
/test e2e-openstack-kuryr |
dulek
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@dulek: This pull request references Jira Issue OCPBUGS-18517, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/severity-critical
|
@dulek: This pull request references Jira Issue OCPBUGS-18517, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
/lgtm |
Since openshift#1952 `network.Render` is no longer supplied with operConfig used later, but a copy of it. This means that MTU set by Kuryr's render phase won't be used for setting the Network.Status and will lead to panic. We have this issue because for Kuryr default MTU is detected on bootstrap phase and there's no fixed value. This commit solves this by making "0" a default value for Kuryr's MTU. Having 0 means that Kuryr will attempt to autodetect the MTU. Moreover the MTU on KuryrConfig will now be set on bootstrap phase, so update of the OperConfig done after the bootstrap phase will make sure to update it too.
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/test e2e-openstack-kuryr |
|
/test e2e-aws-sdn-multi |
|
/test e2e-aws-sdn-network-migration-rollback |
|
/test e2e-openstack-sdn |
|
/test e2e-openstack-kuryr |
1 similar comment
|
/test e2e-openstack-kuryr |
|
/lgtm |
|
/hold cancel The Kuryr jobs still fails the tests and we link this with upgrade of our testing cloud to OSP 17.1. This PR however unblocks the job to pass the installation, so it's a significant progress. I'd like to get this merged even with the job failing. |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/jira refresh |
openshift-ci-robot
added
jira/invalid-bug
|
@dulek: This pull request references Jira Issue OCPBUGS-18517, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@dulek: This pull request references Jira Issue OCPBUGS-18517, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, gryf, knobunc, MaysaMacedo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/label acknowledge-critical-fixes-only |
openshift-ci
Bot
added
the
acknowledge-critical-fixes-only
|
/cherry-pick release-4.14 |
|
@dulek: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Just to be sure if UI isn't hiding some label to me. |
|
@dulek: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@dulek: Jira Issue OCPBUGS-18517: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-18517 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dulek: new pull request created: #1995 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR openshift#1988 introduced a bug causing upgrades to fail, because even when Kuryr MTU was detected from the previous version of the KuryrConfig, CNO would override it to 0. This commit fixes that.
7 participants
Since #1952
network.Renderis no longer supplied with operConfig used later, but a copy of it. This means that MTU set by Kuryr's render phase won't be used for setting the Network.Status and will lead to panic.We have this issue because for Kuryr default MTU is detected on bootstrap phase and there's no fixed value.
This commit solves this by making "0" a default value for Kuryr's MTU. Having 0 means that Kuryr will attempt to autodetect the MTU. Moreover the MTU on KuryrConfig will now be set on bootstrap phase, so update of the OperConfig done after the bootstrap phase will make sure to update it too.