OCPBUGS-19377: Kuryr: Fix deriving MTU from previous config by dulek · Pull Request #2007 · openshift/cluster-network-operator

dulek · 2023-09-19T10:20:01Z

PR #1988 introduced a bug causing upgrades to fail, because even when Kuryr MTU was detected from the previous version of the KuryrConfig, CNO would override it to 0. This commit fixes that.

openshift-ci-robot · 2023-09-19T10:20:06Z

@dulek: This pull request references Jira Issue OCPBUGS-19377, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2023-09-19T10:21:11Z

/jira refresh

openshift-ci-robot · 2023-09-19T10:21:20Z

@dulek: This pull request references Jira Issue OCPBUGS-19377, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2023-09-19T10:21:41Z

/test e2e-openstack-kuryr

dulek · 2023-09-19T10:33:42Z

/cc @MaysaMacedo @gryf

openshift-ci-robot · 2023-09-19T10:33:48Z

@dulek: This pull request references Jira Issue OCPBUGS-19377. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-19T10:33:50Z

@dulek: This pull request references Jira Issue OCPBUGS-19377, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2023-09-19T10:33:53Z

/cc @MaysaMacedo @gryf

dulek · 2023-09-19T10:42:20Z

/retest-required

MaysaMacedo · 2023-09-19T11:51:55Z

@dulek would you mind adding a commit message? Thanks

PR openshift#1988 introduced a bug causing upgrades to fail, because even when Kuryr MTU was detected from the previous version of the KuryrConfig, CNO would override it to 0. This commit fixes that.

openshift-ci-robot · 2023-09-19T12:16:43Z

@dulek: This pull request references Jira Issue OCPBUGS-19377, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

Details

In response to this:

PR #1988 introduced a bug causing upgrades to fail, because even when
Kuryr MTU was detected from the previous version of the KuryrConfig,
CNO would override it to 0. This commit fixes that.
@dulek

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-09-19T12:16:53Z

@dulek: This pull request references Jira Issue OCPBUGS-19377, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

Details

In response to this:

PR #1988 introduced a bug causing upgrades to fail, because even when Kuryr MTU was detected from the previous version of the KuryrConfig, CNO would override it to 0. This commit fixes that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dulek · 2023-09-19T12:16:59Z

@dulek would you mind adding a commit message? Thanks

Done.

MaysaMacedo · 2023-09-19T15:02:24Z

/lgtm
/approve
/retest

MaysaMacedo · 2023-09-19T15:04:33Z

/lgtm

dulek · 2023-09-19T15:24:37Z

/test e2e-openstack-kuryr

dulek · 2023-09-20T09:23:34Z

/test e2e-openstack-kuryr
/retest-required

dulek · 2023-09-20T14:59:45Z

/retest-required

Installation with Kuryr passed, tests failed. This is the current situation due to https://issues.redhat.com/browse/OCPBUGS-18818 which we investigate, but this patch should be good to go.

dcbw · 2023-09-21T14:58:41Z

/approve

openshift-ci · 2023-09-21T15:01:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, dulek, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-09-21T15:19:05Z

/retest-required

Remaining retests: 0 against base HEAD 6888ace and 2 for PR HEAD 8c3a513 in total

openshift-ci-robot · 2023-09-21T19:06:50Z

/retest-required

Remaining retests: 0 against base HEAD c097483 and 1 for PR HEAD 8c3a513 in total

dulek · 2023-09-22T07:41:35Z

/retest-required

openshift-ci · 2023-09-22T10:55:33Z

@dulek: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-network-mtu-migration-ovn-ipv4	`8c3a513`	link	false	`/test e2e-network-mtu-migration-ovn-ipv4`
ci/prow/e2e-vsphere-ovn	`8c3a513`	link	false	`/test e2e-vsphere-ovn`
ci/prow/e2e-vsphere-ovn-dualstack	`8c3a513`	link	false	`/test e2e-vsphere-ovn-dualstack`
ci/prow/e2e-ovn-step-registry	`8c3a513`	link	false	`/test e2e-ovn-step-registry`
ci/prow/e2e-ovn-hybrid-step-registry	`8c3a513`	link	false	`/test e2e-ovn-hybrid-step-registry`
ci/prow/e2e-network-mtu-migration-sdn-ipv4	`8c3a513`	link	false	`/test e2e-network-mtu-migration-sdn-ipv4`
ci/prow/e2e-ovn-ipsec-step-registry	`8c3a513`	link	false	`/test e2e-ovn-ipsec-step-registry`
ci/prow/e2e-openstack-kuryr	`8c3a513`	link	false	`/test e2e-openstack-kuryr`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-09-22T12:53:06Z

/retest-required

Remaining retests: 0 against base HEAD bc8c360 and 0 for PR HEAD 8c3a513 in total

openshift-ci-robot · 2023-09-22T18:31:36Z

@dulek: Jira Issue OCPBUGS-19377: All pull requests linked via external trackers have merged:

openshift/cluster-network-operator#2007

Jira Issue OCPBUGS-19377 has been moved to the MODIFIED state.

Details

In response to this:

PR #1988 introduced a bug causing upgrades to fail, because even when Kuryr MTU was detected from the previous version of the KuryrConfig, CNO would override it to 0. This commit fixes that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-09-27T15:53:43Z

Fix included in accepted release 4.15.0-0.nightly-2023-09-27-073353

openshift-ci Bot requested review from danwinship and tssurya September 19, 2023 10:24

dulek closed this Sep 19, 2023

dulek reopened this Sep 19, 2023

openshift-ci Bot requested review from MaysaMacedo and gryf September 19, 2023 10:33

Kuryr: Fix deriving MTU from previous config

8c3a513

PR openshift#1988 introduced a bug causing upgrades to fail, because even when Kuryr MTU was detected from the previous version of the KuryrConfig, CNO would override it to 0. This commit fixes that.

dulek force-pushed the OCPBUGS-19377 branch from 4477287 to 8c3a513 Compare September 19, 2023 12:16

openshift-ci Bot assigned MaysaMacedo Sep 19, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023

openshift-merge-robot merged commit 90cc246 into openshift:master Sep 22, 2023

jcaamano mentioned this pull request Sep 25, 2023

OCPBUGS-18396: Fix config status MTU migration not being updated #2021

Merged

Conversation

dulek commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 19, 2023

Uh oh!

dulek commented Sep 19, 2023

Uh oh!

openshift-ci-robot commented Sep 19, 2023

Uh oh!

dulek commented Sep 19, 2023

Uh oh!

dulek commented Sep 19, 2023

Uh oh!

openshift-ci-robot commented Sep 19, 2023

Uh oh!

openshift-ci-robot commented Sep 19, 2023

Uh oh!

dulek commented Sep 19, 2023

Uh oh!

dulek commented Sep 19, 2023

Uh oh!

MaysaMacedo commented Sep 19, 2023

Uh oh!

openshift-ci-robot commented Sep 19, 2023

Uh oh!

openshift-ci-robot commented Sep 19, 2023

Uh oh!

dulek commented Sep 19, 2023

Uh oh!

MaysaMacedo commented Sep 19, 2023

Uh oh!

MaysaMacedo commented Sep 19, 2023

Uh oh!

dulek commented Sep 19, 2023

Uh oh!

dulek commented Sep 20, 2023

Uh oh!

dulek commented Sep 20, 2023

Uh oh!

dcbw commented Sep 21, 2023

Uh oh!

openshift-ci Bot commented Sep 21, 2023

Uh oh!

openshift-ci-robot commented Sep 21, 2023

Uh oh!

openshift-ci-robot commented Sep 21, 2023

Uh oh!

dulek commented Sep 22, 2023

Uh oh!

openshift-ci Bot commented Sep 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 22, 2023

Uh oh!

openshift-ci-robot commented Sep 22, 2023

Uh oh!

openshift-merge-robot commented Sep 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dulek commented Sep 19, 2023 •

edited

Loading

openshift-ci Bot commented Sep 22, 2023 •

edited

Loading