[release-4.4] mount /var/run shared#573
[release-4.4] mount /var/run shared#573haircommander wants to merge 1 commit intoopenshift:release-4.4from
Conversation
|
@haircommander: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@haircommander: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| # TODO: remove | ||
| - mountPath: /var/run | ||
| name: host-var-run | ||
| mountPropegation: Bidirectional |
There was a problem hiding this comment.
Shouldn't it be mountPropagation?
https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation
There was a problem hiding this comment.
I knew I should copy and paste it, spelling is hard 🙃 fixed!
When trying to transfer cri-o to manage its network namespaces in openshift, we have run into problems with multus. Specifically we see the error: 2020-04-07T17:46:52Z [error] delegateAdd: error invoking DelegateAdd - "ovn-k8s-cni-overlay": error in getting result from AddNetwork: CNI request failed with status 400: '[openshift-dns/dns-default-98tll] failed to configure pod interface: failed to open netns "/var/run/netns/76716600-f7fd-462f-b7df-ae054dbd144e": unknown FS magic on "/var/run/netns/76716600-f7fd-462f-b7df-ae054dbd144e": 1021994 ' through testing, I've found the netns is definitely mounted as an nsfs and not tmpfs, so I suspect we are seeing containernetworking/plugins#69 to fix this, attempt mounting /var/run/{,netns} as Bidirectional Signed-off-by: Peter Hunt <pehunt@redhat.com>
1e4c553 to
f6d99be
Compare
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
taking this over in #576 |
When trying to transfer cri-o to manage its network namespaces in openshift, we have run into problems with multus. Specifically we see the error:
through testing, I've found the netns is definitely mounted as an nsfs and not tmpfs, so I suspect we are seeing containernetworking/plugins#69
to fix this, attempt mounting /var/run/{,netns} as Bidirectional
This PR is to aid in the kata effort. right now, it's only a WIP, and the release image created will be used to test if it actually works. It's targeted at 4.4 because that's what is being used for other kata related tests right now. If this actually works, I will first target a PR at master and then go through the backporting rigmarole. but feedback is definitely welcome here 😄