Skip to content

WIP [release-4.4] mount /var/run shared for ovnkube#576

Closed
haircommander wants to merge 1 commit intoopenshift:release-4.4from
haircommander:bidirectional-netns-ovnkube
Closed

WIP [release-4.4] mount /var/run shared for ovnkube#576
haircommander wants to merge 1 commit intoopenshift:release-4.4from
haircommander:bidirectional-netns-ovnkube

Conversation

@haircommander
Copy link
Copy Markdown
Member

this is a part of #573. I hit with a heavy hammer yesterday to verify the approach was correct, now I need to figure out which yaml fix was needed (I suspect I don't need to make all the changes in 573)

creating a PR because it's the only way I know how to test it /shrug

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@haircommander: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

WIP [release-4.4] mount /var/run shared for ovnkube

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander
To complete the pull request process, please assign squeed
You can assign the PR to them by writing /assign @squeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haircommander haircommander force-pushed the bidirectional-netns-ovnkube branch from a8e016e to d0f72d4 Compare April 8, 2020 15:32
When trying to transfer cri-o to manage its network namespaces in openshift, we have run into problems with multus. Specifically we see the error:
2020-04-07T17:46:52Z [error] delegateAdd: error invoking DelegateAdd - "ovn-k8s-cni-overlay": error in getting result from AddNetwork: CNI request failed with status 400: '[openshift-dns/dns-default-98tll] failed to configure pod interface: failed to open netns "/var/run/netns/76716600-f7fd-462f-b7df-ae054dbd144e": unknown FS magic on "/var/run/netns/76716600-f7fd-462f-b7df-ae054dbd144e": 1021994
'

through testing, I've found the netns is definitely mounted as an nsfs and not tmpfs, so I suspect we are seeing containernetworking/plugins#69

to fix this, attempt mounting /var/run/netns as Bidirectional in ovnkube container

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander force-pushed the bidirectional-netns-ovnkube branch 2 times, most recently from 1746327 to 097c048 Compare April 9, 2020 16:41
@fidencio
Copy link
Copy Markdown

fidencio commented Apr 9, 2020

I've tested this PR and it does solve the issue I've faced with kata, when combined with cri-o/cri-o#3530 (plus two patches @haircommander must likely would like to have added to that cri-o PR ;-)).

It's worth to mention that I've faced some OVN weirdness, such as:
evel=error msg="Error while checking pod to CNI network \"multus-cni-network\": neither IPv4 nor IPv6 found when retrieving network status: [Unexpected com...

I'm not confident to say the error faced aboved is related to this patch, as my environment is far from stable (it's an azure cluster spawned using cluster bot with kata installed via a bleeding edge, with known issues, DaemonSet);

Thanks for digging this out, @haircommander!

@haircommander
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@haircommander: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 097c048 link /test e2e-gcp
ci/prow/e2e-gcp-ovn 097c048 link /test e2e-gcp-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants