WIP [release-4.4] mount /var/run shared for ovnkube#576
WIP [release-4.4] mount /var/run shared for ovnkube#576haircommander wants to merge 1 commit intoopenshift:release-4.4from
Conversation
|
@haircommander: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
a8e016e to
d0f72d4
Compare
When trying to transfer cri-o to manage its network namespaces in openshift, we have run into problems with multus. Specifically we see the error: 2020-04-07T17:46:52Z [error] delegateAdd: error invoking DelegateAdd - "ovn-k8s-cni-overlay": error in getting result from AddNetwork: CNI request failed with status 400: '[openshift-dns/dns-default-98tll] failed to configure pod interface: failed to open netns "/var/run/netns/76716600-f7fd-462f-b7df-ae054dbd144e": unknown FS magic on "/var/run/netns/76716600-f7fd-462f-b7df-ae054dbd144e": 1021994 ' through testing, I've found the netns is definitely mounted as an nsfs and not tmpfs, so I suspect we are seeing containernetworking/plugins#69 to fix this, attempt mounting /var/run/netns as Bidirectional in ovnkube container Signed-off-by: Peter Hunt <pehunt@redhat.com>
1746327 to
097c048
Compare
|
I've tested this PR and it does solve the issue I've faced with kata, when combined with cri-o/cri-o#3530 (plus two patches @haircommander must likely would like to have added to that cri-o PR ;-)). It's worth to mention that I've faced some OVN weirdness, such as: I'm not confident to say the error faced aboved is related to this patch, as my environment is far from stable (it's an azure cluster spawned using cluster bot with kata installed via a bleeding edge, with known issues, DaemonSet); Thanks for digging this out, @haircommander! |
|
/retest |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
this is a part of #573. I hit with a heavy hammer yesterday to verify the approach was correct, now I need to figure out which yaml fix was needed (I suspect I don't need to make all the changes in 573)
creating a PR because it's the only way I know how to test it /shrug