Skip to content

Bug 1838251: The DHCP CNI daemonset should mount the netns paths#645

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dougbtv:dhcp-mount-volume
May 26, 2020
Merged

Bug 1838251: The DHCP CNI daemonset should mount the netns paths#645
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dougbtv:dhcp-mount-volume

Conversation

@dougbtv
Copy link
Copy Markdown
Contributor

@dougbtv dougbtv commented May 21, 2020

Otherwise, it can fail with out being able to locate the netns paths under OCP 4.5

@dougbtv
Copy link
Copy Markdown
Contributor Author

dougbtv commented May 21, 2020

/retitle Bug 1838251: The DHCP CNI daemonset should mount the netns paths

@openshift-ci-robot openshift-ci-robot changed the title The DHCP CNI daemonset should mount the netns paths Bug 1838251: The DHCP CNI daemonset should mount the netns paths May 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 21, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 21, 2020

@dougbtv: This pull request references Bugzilla bug 1838251, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1838251: The DHCP CNI daemonset should mount the netns paths

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougbtv
dougbtv commented May 21, 2020
View reviewed changes
Comment thread bindata/network/multus/003-dhcp-daemon.yaml Outdated
mountPath: /host/proc
- name: netnspath
mountPath: /host/var/run/netns
mountPropagation: Bidirectional
Copy link
Copy Markdown
Contributor Author

@dougbtv dougbtv May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an FYI that this was required otherwise I was getting complaints about wrong fs magic.

Copy link
Copy Markdown
Contributor

@s1061123 s1061123 May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bidirectional or HostToContainer could be okey. see: https://github.com/openshift/cluster-network-operator/pull/579/files

Copy link
Copy Markdown
Contributor

@danwinship danwinship May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please make it HostToContainer if that works. More securer.

@dougbtv dougbtv force-pushed the dhcp-mount-volume branch from 82246ff to 3b0cf89 Compare May 21, 2020 20:26
@s1061123 s1061123 mentioned this pull request May 25, 2020
Closed
@dougbtv
The DHCP CNI daemonset should mount the netns paths
4bf2396 
Otherwise, it can fail with out being able to locate the netns paths under OCP 4.5
@dougbtv dougbtv force-pushed the dhcp-mount-volume branch from 3b0cf89 to 4bf2396 Compare May 26, 2020 12:43
@dougbtv
Copy link
Copy Markdown
Contributor Author

dougbtv commented May 26, 2020

Pushed new commit with mountPropagation: HostToContainer

@danwinship
Copy link
Copy Markdown
Contributor

danwinship commented May 26, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 26, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, dougbtv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 26, 2020 •
edited
Loading

@dougbtv: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi 4bf2396 link /test e2e-metal-ipi

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 26, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a39b913 into openshift:master May 26, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 26, 2020

@dougbtv: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#645. Bugzilla bug 1838251 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1838251: The DHCP CNI daemonset should mount the netns paths

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander haircommander mentioned this pull request Jun 16, 2020
Merged
@haircommander
Copy link
Copy Markdown
Member

haircommander commented Jun 26, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jun 26, 2020

@haircommander: new pull request created: #681

Details

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 26, 2020
Merged
@haircommander haircommander mentioned this pull request Jun 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danwinship danwinship danwinship left review comments

@juanluisvaladas juanluisvaladas Awaiting requested review from juanluisvaladas

@squeed squeed Awaiting requested review from squeed

+1 more reviewer

@s1061123 s1061123 s1061123 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@danwinship danwinship

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dougbtv @openshift-ci-robot @danwinship @openshift-bot @haircommander @openshift-cherrypick-robot @s1061123 @openshift-merge-robot