Bug 1825339: [4.4] crio: manage ns lifecycle by haircommander · Pull Request #1871 · openshift/machine-config-operator

haircommander · 2020-06-24T19:41:01Z

- What I did
change the entry in crio.conf template to manage ns lifecycle
As it is more secure and gives cri-o more control of namespace lifecycle. Also change the outdated config name value

backport of #1689

- How to verify it

- Description for the changelog

CRI-O now manages namespace lifecycle

change the entry in crio.conf template to manage ns lifecycle As it is more secure and gives cri-o more control of namespace lifecycle. Also change the outdated config name value Signed-off-by: Peter Hunt <pehunt@redhat.com>

openshift-ci-robot · 2020-06-24T19:41:09Z

@haircommander: This pull request references Bugzilla bug 1825339, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1820118 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1820118 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

Bug 1825339: [4.4] crio: manage ns lifecycle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kikisdeliveryservice · 2020-06-24T19:51:41Z

/retest

haircommander · 2020-06-25T19:28:13Z

/retest

kikisdeliveryservice · 2020-06-25T20:15:52Z

/skip

kikisdeliveryservice · 2020-06-25T20:17:39Z

/assign @umohnani8 @mtrmac

kikisdeliveryservice · 2020-06-26T17:10:46Z

/skip

haircommander · 2020-06-26T17:16:35Z

/test e2e-metal-ipi

haircommander · 2020-06-26T17:19:56Z

we may need some variation of openshift/cluster-network-operator#645

I think we should wait till next week on this

rphillips · 2020-06-26T17:28:45Z

Holding until next week... Feel free to remove.

/hold

dulek · 2020-06-29T11:17:34Z

For sure we need openshift/cluster-network-operator#684 to get in before this.

luis5tb · 2020-07-06T06:42:45Z

This got already merged: openshift/cluster-network-operator#684

haircommander · 2020-07-06T13:51:56Z

excellent!

openshift-ci-robot · 2020-07-06T13:51:59Z

@haircommander: This pull request references Bugzilla bug 1825339. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1825339: [4.4] crio: manage ns lifecycle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-07-06T13:54:23Z

excellent!

openshift-ci-robot · 2020-07-06T13:54:27Z

@haircommander: This pull request references Bugzilla bug 1825339, which is invalid:

expected the bug to be open, but it isn't
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1825339: [4.4] crio: manage ns lifecycle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-07-06T13:54:53Z

I confused myself, this was not meant to be closed

haircommander · 2020-07-06T13:55:37Z

/bugzilla refresh

openshift-ci-robot · 2020-07-06T13:55:42Z

@haircommander: This pull request references Bugzilla bug 1825339, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1820118 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1820118 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-07-06T17:40:03Z

/test e2e-aws

umohnani8 · 2020-07-08T21:03:18Z

/lgtm

openshift-ci-robot · 2020-07-08T21:03:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kikisdeliveryservice, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

haircommander · 2020-07-08T21:36:57Z

/hold cancel

the dependent PRs have all merged

openshift-bot · 2020-07-08T22:47:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-08T23:00:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

kikisdeliveryservice · 2020-07-08T23:09:36Z

/skip

openshift-bot · 2020-07-09T00:31:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-07-09T05:31:55Z

@haircommander: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1871. Bugzilla bug 1825339 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1825339: [4.4] crio: manage ns lifecycle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crio: manage ns lifecycle

1a4ed8b

change the entry in crio.conf template to manage ns lifecycle As it is more secure and gives cri-o more control of namespace lifecycle. Also change the outdated config name value Signed-off-by: Peter Hunt <pehunt@redhat.com>

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 24, 2020

openshift-ci-robot requested review from mtrmac and umohnani8 June 24, 2020 19:41

kikisdeliveryservice approved these changes Jun 25, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020

openshift-ci-robot assigned mtrmac and umohnani8 Jun 25, 2020

haircommander mentioned this pull request Jun 26, 2020

[release-4.4] Bug 1851489: The DHCP CNI daemonset should mount the netns paths openshift/cluster-network-operator#681

Merged

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2020

mtrmac removed their assignment Jun 26, 2020

dulek mentioned this pull request Jun 29, 2020

[release-4.4] Bug 1851903: Kuryr: Mount /run/netns to ensure netns access openshift/cluster-network-operator#684

Merged

haircommander closed this Jul 6, 2020

haircommander reopened this Jul 6, 2020

openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 6, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 6, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 6, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 6, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 8, 2020

openshift-merge-robot merged commit 1cb23e0 into openshift:release-4.4 Jul 9, 2020

Conversation

haircommander commented Jun 24, 2020

Uh oh!

openshift-ci-robot commented Jun 24, 2020

Uh oh!

kikisdeliveryservice commented Jun 24, 2020

Uh oh!

haircommander commented Jun 25, 2020

Uh oh!

kikisdeliveryservice commented Jun 25, 2020

Uh oh!

kikisdeliveryservice commented Jun 25, 2020

Uh oh!

kikisdeliveryservice commented Jun 26, 2020

Uh oh!

haircommander commented Jun 26, 2020

Uh oh!

haircommander commented Jun 26, 2020

Uh oh!

rphillips commented Jun 26, 2020

Uh oh!

dulek commented Jun 29, 2020

Uh oh!

luis5tb commented Jul 6, 2020

Uh oh!

haircommander commented Jul 6, 2020

Uh oh!

openshift-ci-robot commented Jul 6, 2020

Uh oh!

haircommander commented Jul 6, 2020

Uh oh!

openshift-ci-robot commented Jul 6, 2020

Uh oh!

haircommander commented Jul 6, 2020

Uh oh!

haircommander commented Jul 6, 2020

Uh oh!

openshift-ci-robot commented Jul 6, 2020

Uh oh!

haircommander commented Jul 6, 2020

Uh oh!

umohnani8 commented Jul 8, 2020

Uh oh!

openshift-ci-robot commented Jul 8, 2020

Uh oh!

haircommander commented Jul 8, 2020

Uh oh!

openshift-bot commented Jul 8, 2020

Uh oh!

openshift-bot commented Jul 8, 2020

Uh oh!

kikisdeliveryservice commented Jul 8, 2020

Uh oh!

openshift-bot commented Jul 9, 2020

Uh oh!

openshift-ci-robot commented Jul 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants