Bug 1831866: cri-o: manage ns lifecycle, again! by haircommander · Pull Request #1689 · openshift/machine-config-operator

haircommander · 2020-04-27T15:02:41Z

- What I did
change the entry in crio.conf template to manage ns lifecycle
As it is more secure and gives cri-o more control of namespace lifecycle

This is attempting to do what #1568 did, but now we've hopefully ironed out the issues that caused the need for #1600

- How to verify it

- Description for the changelog

CRI-O now manages namespace lifecycle

switch cri-o to manage namespace lifecycle again, after having ironed out some details with third party networking plugins Signed-off-by: Peter Hunt <pehunt@redhat.com>

haircommander · 2020-04-27T15:04:20Z

btw @stbenjam @dulek as this broke y'all last time 😄 , and hopefully will no longer do so

mrunalp · 2020-04-27T18:21:58Z

/hold to inspect the artifacts before merging.

stbenjam · 2020-04-28T11:28:51Z

e2e-metal-ipi passed, so I think this time it's good.

haircommander · 2020-04-28T13:36:45Z

/retest

I'm running the e2e-network-stress test with clusterbot. that should give us an idea of how this is doing

I also verified that this PR is working as expected, though I only poked through the artifacts briefly

haircommander · 2020-04-28T15:55:48Z

job test e2e-network-stress openshift/machine-config-operator#1689 succeeded
assuming that cluster bot did the right thing, then hooray 😄

haircommander · 2020-04-28T15:56:40Z

does this work?

/test e2e-network-stress

edit: no

openshift-ci-robot · 2020-04-28T15:56:55Z

@haircommander: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test e2e-aws
/test e2e-aws-disruptive
/test e2e-aws-scaleup-rhel7
/test e2e-gcp-op
/test e2e-gcp-upgrade
/test e2e-metal-ipi
/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere
/test images
/test unit
/test verify

Use /test all to run all jobs.

Details

In response to this:

does this work?

/test e2e-network-stress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift/machine-config-operator#1689 moves pod namespaces from /proc into /var/run/netns. As Kuryr needs access to them in order to manipulate interfaces, we need to mount the new directory and this commit does that.

dulek · 2020-04-29T09:41:21Z

Alright, so along with openshift/cluster-network-operator#562 this seem to work just fine. :)

haircommander · 2020-05-04T16:27:11Z

/retest

openshift/machine-config-operator#1689 moves pod namespaces from /proc into /run/netns. As Kuryr needs access to them in order to manipulate interfaces, we need to mount the new directory and this commit does that. Note that CNI will pass /var/run/netns in netns paths, but /var/run is a symlink to /run, so it should be just fine.

haircommander · 2020-05-05T18:54:03Z

/retest

openshift-ci-robot · 2020-05-05T19:07:16Z

@haircommander: This pull request references Bugzilla bug 1831866, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1831866: cri-o: manage ns lifecycle, again!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-05-05T19:07:16Z

/bugzilla refresh

openshift-ci-robot · 2020-05-05T19:07:19Z

@haircommander: This pull request references Bugzilla bug 1831866, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-05-05T19:09:01Z

we've gotten +1 from kuryr team and metal IPI teams, as well as tested with ovs and ovn, and run network stress tests.

PTAL @umohnani8 @mrunalp I believe this is ready.

openshift/machine-config-operator#1689 moves pod namespaces from /proc into /run/netns. As Kuryr needs access to them in order to manipulate interfaces, we need to mount the new directory and this commit does that. Note that CNI will pass /var/run/netns in netns paths, but /var/run is a symlink to /run, so it should be just fine.

haircommander · 2020-05-07T20:27:20Z

/retest

haircommander · 2020-05-08T14:06:38Z

could not wait for build: the build machine-config-operator failed after 3m30s with reason DockerBuildFailed: Docker build strategy has failed.
/retest

mrunalp · 2020-05-08T17:09:31Z

/lgtm

openshift-bot · 2020-05-12T06:53:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T08:49:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T10:33:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T12:17:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T12:30:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T14:14:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T16:50:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T18:47:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T19:00:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

haircommander · 2020-05-12T19:16:56Z

@runcom @kikisdeliveryservice @sinnykumari @yuqi-zhang can we skip gcp-op? It passed organically in CI before the timeouts started happening, and I ran them manually on a gcp cluster with a bumped timeout and they passed. I'd like this to have some soak time before 4.5 freeze to make sure we have time to react to issues if there are any

yuqi-zhang · 2020-05-12T20:24:40Z

I can confirm that it did pass at some point. I'm going to go ahead and override

yuqi-zhang · 2020-05-12T20:24:43Z

/override e2e-gcp-op

yuqi-zhang · 2020-05-12T20:25:25Z

/override ci/prow/e2e-gcp-op

openshift-ci-robot · 2020-05-12T20:25:57Z

@yuqi-zhang: /override requires a failed status context to operate on.
The following unknown contexts were given:

e2e-gcp-op

Only the following contexts were expected:

ci/prow/e2e-aws
ci/prow/e2e-aws-scaleup-rhel7
ci/prow/e2e-gcp-op
ci/prow/e2e-gcp-upgrade
ci/prow/e2e-metal-ipi
ci/prow/images
ci/prow/unit
ci/prow/verify
tide

Details

In response to this:

/override e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-12T20:30:19Z

@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-gcp-op

Details

In response to this:

/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

haircommander · 2020-05-12T20:39:27Z

I can confirm that it did pass at some point. I'm going to go ahead and override

thanks!

openshift-bot · 2020-05-12T20:57:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T21:36:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-12T23:07:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T00:51:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T02:35:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T04:32:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-13T05:37:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sinnykumari · 2020-05-13T07:27:00Z

since e2e-gcp-op test has already passed earlier, attempting to override again to get this merged
/override ci/prow/e2e-gcp-op

openshift-ci-robot · 2020-05-13T07:27:57Z

@sinnykumari: Overrode contexts on behalf of sinnykumari: ci/prow/e2e-gcp-op

Details

In response to this:

since e2e-gcp-op test has already passed earlier, attempting to override again to get this merged
/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-13T07:31:12Z

@haircommander: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1689. Bugzilla bug 1831866 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1831866: cri-o: manage ns lifecycle, again!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift/machine-config-operator#1689 moves pod namespaces from /proc into /run/netns. As Kuryr needs access to them in order to manipulate interfaces, we need to mount the new directory and this commit does that. Note that CNI will pass /var/run/netns in netns paths, but /var/run is a symlink to /run, so it should be just fine.

cri-o: manage ns lifecycle, again!

601bc22

switch cri-o to manage namespace lifecycle again, after having ironed out some details with third party networking plugins Signed-off-by: Peter Hunt <pehunt@redhat.com>

openshift-ci-robot requested review from mtrmac and umohnani8 April 27, 2020 15:03

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2020

MaysaMacedo mentioned this pull request May 4, 2020

Bug 1831112: Kuryr: Mount /run/netns to ensure netns access openshift/cluster-network-operator#562

Merged

haircommander changed the title ~~cri-o: manage ns lifecycle, again!~~ Bug 1831866: cri-o: manage ns lifecycle, again! May 5, 2020

openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 5, 2020

openshift-ci-robot assigned mrunalp May 8, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2020

openshift-merge-robot merged commit 3be112d into openshift:master May 13, 2020

stbenjam mentioned this pull request May 13, 2020

Bug 1823950: [baremetal] Switch to /readyz for haproxy healthchecking #1724

Merged

haircommander mentioned this pull request Jun 24, 2020

Bug 1825339: [4.4] crio: manage ns lifecycle #1871

Merged

Conversation

haircommander commented Apr 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

haircommander commented Apr 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrunalp commented Apr 27, 2020

Uh oh!

stbenjam commented Apr 28, 2020

Uh oh!

haircommander commented Apr 28, 2020

Uh oh!

haircommander commented Apr 28, 2020

Uh oh!

haircommander commented Apr 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 28, 2020

Uh oh!

dulek commented Apr 29, 2020

Uh oh!

haircommander commented May 4, 2020

Uh oh!

haircommander commented May 5, 2020

Uh oh!

openshift-ci-robot commented May 5, 2020

Uh oh!

haircommander commented May 5, 2020

Uh oh!

openshift-ci-robot commented May 5, 2020

Uh oh!

haircommander commented May 5, 2020

Uh oh!

haircommander commented May 7, 2020

Uh oh!

haircommander commented May 8, 2020

Uh oh!

mrunalp commented May 8, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

haircommander commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuqi-zhang commented May 12, 2020

Uh oh!

yuqi-zhang commented May 12, 2020

Uh oh!

yuqi-zhang commented May 12, 2020

Uh oh!

openshift-ci-robot commented May 12, 2020

Uh oh!

openshift-ci-robot commented May 12, 2020

Uh oh!

haircommander commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 12, 2020

Uh oh!

openshift-bot commented May 13, 2020

haircommander commented Apr 27, 2020 •

edited

Loading

haircommander commented Apr 27, 2020 •

edited

Loading

haircommander commented Apr 28, 2020 •

edited

Loading

haircommander commented May 12, 2020 •

edited

Loading