Skip to content

[release-4.4] Bug 1851903: Kuryr: Mount /run/netns to ensure netns access#684

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-562-to-release-4.4
Jul 3, 2020
Merged

[release-4.4] Bug 1851903: Kuryr: Mount /run/netns to ensure netns access#684
openshift-merge-robot merged 1 commit intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-562-to-release-4.4

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 29, 2020

This is an automated cherry-pick of #562

/assign dulek

@dulek
Kuryr: Mount /run/netns to ensure netns access
75555b4 
openshift/machine-config-operator#1689 moves pod namespaces from
/proc into /run/netns. As Kuryr needs access to them in order to
manipulate interfaces, we need to mount the new directory and this
commit does that.

Note that CNI will pass /var/run/netns in netns paths, but /var/run is a
symlink to /run, so it should be just fine.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 29, 2020
Merged
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 29, 2020

@openshift-cherrypick-robot: Bugzilla bug 1831112 has been cloned as Bugzilla bug 1851903. Retitling PR to link against new bug.
/retitle [release-4.4] Bug 1851903: Kuryr: Mount /run/netns to ensure netns access

Details

In response to this:

[release-4.4] Bug 1831112: Kuryr: Mount /run/netns to ensure netns access

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1831112: Kuryr: Mount /run/netns to ensure netns access [release-4.4] Bug 1851903: Kuryr: Mount /run/netns to ensure netns access Jun 29, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 29, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 29, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1851903, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1831112 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1831112 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

[release-4.4] Bug 1851903: Kuryr: Mount /run/netns to ensure netns access

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek dulek mentioned this pull request Jun 29, 2020
Merged
@dulek
Copy link
Copy Markdown
Contributor

dulek commented Jun 29, 2020

This is reaction for ongoing backport openshift/machine-config-operator#1871.

@MaysaMacedo
Copy link
Copy Markdown
Contributor

MaysaMacedo commented Jun 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020
@haircommander
Copy link
Copy Markdown
Member

haircommander commented Jun 29, 2020 •
edited
Loading 


TASK [create Packet host ipi-ci-op-rkpl0hid-03fb4-1277561605680271360] *********
fatal: [localhost]: FAILED! => {"censored": "the output has been hidden due to the fact that 'no_log: true' was specified for this result", "changed": false}

doesn't seem related?


[Feature:Prometheus][Late] Alerts [Top Level] [Feature:Prometheus][Late] Alerts shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured [Suite:openshift/conformance/parallel]

also unsure of its relation
/retest

@dulek
Copy link
Copy Markdown
Contributor

dulek commented Jun 29, 2020 


TASK [create Packet host ipi-ci-op-rkpl0hid-03fb4-1277561605680271360] *********
fatal: [localhost]: FAILED! => {"censored": "the output has been hidden due to the fact that 'no_log: true' was specified for this result", "changed": false}

doesn't seem related?


[Feature:Prometheus][Late] Alerts [Top Level] [Feature:Prometheus][Late] Alerts shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured [Suite:openshift/conformance/parallel]

also unsure of its relation
/retest

For sure not related, we don't have any tests executing those code paths in the gate (which is obviously awful, but what can I do?).

@haircommander
Copy link
Copy Markdown
Member

haircommander commented Jun 29, 2020 •
edited
Loading

@kuryr-approvers PTAL

edit: i guess this alias doesn't work

@dulek
Copy link
Copy Markdown
Contributor

dulek commented Jun 30, 2020

/approve

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@dulek
Copy link
Copy Markdown
Contributor

dulek commented Jun 30, 2020 •
edited
Loading

This needs /cherry-pick-approve from release maintainer anyway.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 2, 2020
@luis5tb
Copy link
Copy Markdown
Contributor

luis5tb commented Jul 3, 2020

/retest

@luis5tb
Copy link
Copy Markdown
Contributor

luis5tb commented Jul 3, 2020

/test e2e-gcp

@openshift-merge-robot openshift-merge-robot merged commit 13ac813 into openshift:release-4.4 Jul 3, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 3, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#684. Bugzilla bug 1851903 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1851903: Kuryr: Mount /run/netns to ensure netns access

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dulek dulek Awaiting requested review from dulek

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

Assignees

@dulek dulek

@MaysaMacedo MaysaMacedo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @dulek @MaysaMacedo @haircommander @luis5tb @sdodson @openshift-merge-robot