Skip to content

[release-4.4] Bug 1851990: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe.#685

Closed
openshift-cherrypick-robot wants to merge 4 commits intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-682-to-release-4.4
Closed

[release-4.4] Bug 1851990: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe.#685
openshift-cherrypick-robot wants to merge 4 commits intoopenshift:release-4.4from
openshift-cherrypick-robot:cherry-pick-682-to-release-4.4

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #682

/assign dcbw

…y-probe.

These timers are currently set to fixed value based on my current observation
from scale tests. We might have to increase these values in future based on
the scale we will be supporting for upcoming release. Currently election-timer
values are limited by the raft jsonrpc inactivity-probe time of 5 seconds as well.
To further increase the election-timer value, we need to disable jsonrpc
inactivity-probe.

Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
…s check

Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
Typo in election_timer was assigning null value that was leading to
failure in setting up the nb-db election-timer (only if you use != 2(n) number).
Seems like it was delaying the deployment of ovnkube-master and
causing issue with ovnkube-node readiness as the flow programming got delayed
and ovnkube-node times out checking for flows.

Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Bugzilla bug 1851518 has been cloned as Bugzilla bug 1851990. Retitling PR to link against new bug.
/retitle [release-4.4] Bug 1851990: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe.

Details

In response to this:

[release-4.4] Bug 1851518: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign squeed
You can assign the PR to them by writing /assign @squeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1851518: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe. [release-4.4] Bug 1851990: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe. Jun 29, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 29, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1851990, which is invalid:

  • expected dependent Bugzilla bug 1851518 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1851990: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Jun 29, 2020

/retest

1 similar comment
@vishnoianil
Copy link
Copy Markdown
Contributor

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-ovn db8f7a8 link /test e2e-gcp-ovn

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Jul 8, 2020

Closing until we know it's required; note that this would also need #697

@dcbw dcbw closed this Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants