[release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job by openshift-cherrypick-robot · Pull Request #697 · openshift/cluster-network-operator

openshift-cherrypick-robot · 2020-07-08T06:55:52Z

This is an automated cherry-pick of #689

/assign vrutkovs

…de job The TargetDown alert was always getting fired for all the ovnkube-nodes because the metrics-bind-address flag was not getting passed in the exec command for the ovnkube-node container. This regression was introduced in PR openshift#615. Prometheus was hence not able to scrape the up metrics. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

openshift-ci-robot · 2020-07-08T06:56:02Z

@openshift-cherrypick-robot: Bugzilla bug 1851928 has been cloned as Bugzilla bug 1854736. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job

Details

In response to this:

[release-4.5] Bug 1851928: [metrics] TargetDown alert is always fired in ovnkube-node job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-07-08T06:56:23Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1854736, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1851928 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 1851928 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

Details

In response to this:

[release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs · 2020-07-08T09:43:44Z

/retest

vrutkovs · 2020-07-08T11:30:06Z

/retest

vrutkovs · 2020-07-08T13:38:15Z

/retest

dcbw · 2020-07-08T14:30:08Z

/lgtm
/approve

openshift-ci-robot · 2020-07-08T14:30:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knobunc · 2020-07-08T15:32:31Z

@sdodson can we get this one approved?

openshift-bot · 2020-07-08T16:04:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dcbw · 2020-07-08T18:07:50Z

/bugzilla refresh

dcbw · 2020-07-08T18:08:40Z

/bugzilla refresh

openshift-ci-robot · 2020-07-08T18:09:29Z

@dcbw: This pull request references Bugzilla bug 1854736, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1851928 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 1851928 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-07-08T18:11:24Z

@dcbw: This pull request references Bugzilla bug 1854736, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1851928 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Bugzilla bug 1851928 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-07-09T13:40:08Z

/bugzilla refresh

openshift-ci-robot · 2020-07-09T13:40:12Z

@sdodson: This pull request references Bugzilla bug 1854736, which is invalid:

expected dependent Bugzilla bug 1851928 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcbw · 2020-07-13T14:50:11Z

aws-sdn-single failure is unrelated to this PR since that job is for openshift-sdn and this is an ovnkube PR. Also looks like a CRIO problem to begin with:

"message": "Failed to create pod sandbox: rpc error: code = Unknown desc = error creating pod sandbox with name \"k8s_sdn-85r8q_openshift-sdn_5c3a5e2e-fcb8-4827-b3a7-7e91e7444925_0\": layer not known",

dcbw · 2020-07-13T14:50:46Z

/override e2e-aws-sdn-single

openshift-ci-robot · 2020-07-13T14:51:00Z

@dcbw: /override requires a failed status context to operate on.
The following unknown contexts were given:

e2e-aws-sdn-single

Only the following contexts were expected:

ci/prow/e2e-aws-sdn-multi
ci/prow/e2e-aws-sdn-single
ci/prow/e2e-gcp
ci/prow/e2e-gcp-upgrade
ci/prow/e2e-metal-ipi
ci/prow/e2e-ovn-hybrid-step-registry
ci/prow/e2e-ovn-step-registry
ci/prow/images
ci/prow/unit
ci/prow/verify
tide

Details

In response to this:

/override e2e-aws-sdn-single

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dcbw · 2020-07-13T14:52:05Z

/override ci/prow/e2e-aws-sdn-single

openshift-ci-robot · 2020-07-13T14:52:21Z

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-sdn-single

Details

In response to this:

/override ci/prow/e2e-aws-sdn-single

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-07-13T15:14:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-07-13T16:59:18Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: openshift/cluster-network-operator#697. Bugzilla bug 1854736 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Jul 8, 2020

Bug 1851928: [metrics] TargetDown alert is always fired in ovnkube-node job #689

Merged

openshift-ci-robot assigned vrutkovs Jul 8, 2020

openshift-ci-robot requested review from alexanderConstantinescu and rcarrillocruz July 8, 2020 06:56

openshift-ci-robot changed the title ~~[release-4.5] Bug 1851928: [metrics] TargetDown alert is always fired in ovnkube-node job~~ [release-4.5] Bug 1854736: [metrics] TargetDown alert is always fired in ovnkube-node job Jul 8, 2020

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 8, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 8, 2020

openshift-ci-robot assigned dcbw Jul 8, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020

dcbw mentioned this pull request Jul 8, 2020

[release-4.4] Bug 1851990: Expose raft (nb-db/sb-db) election-timer and ovn-controller inactivity probe. #685

Closed

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jul 8, 2020

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 9, 2020

openshift-merge-robot merged commit 076a2c6 into openshift:release-4.5 Jul 13, 2020

Conversation

openshift-cherrypick-robot commented Jul 8, 2020

Uh oh!

openshift-ci-robot commented Jul 8, 2020

Uh oh!

openshift-ci-robot commented Jul 8, 2020

Uh oh!

vrutkovs commented Jul 8, 2020

Uh oh!

vrutkovs commented Jul 8, 2020

Uh oh!

vrutkovs commented Jul 8, 2020

Uh oh!

dcbw commented Jul 8, 2020

Uh oh!

openshift-ci-robot commented Jul 8, 2020

Uh oh!

knobunc commented Jul 8, 2020

Uh oh!

openshift-bot commented Jul 8, 2020

Uh oh!

dcbw commented Jul 8, 2020

Uh oh!

dcbw commented Jul 8, 2020

Uh oh!

openshift-ci-robot commented Jul 8, 2020

Uh oh!

openshift-ci-robot commented Jul 8, 2020

Uh oh!

sdodson commented Jul 9, 2020

Uh oh!

openshift-ci-robot commented Jul 9, 2020

Uh oh!

dcbw commented Jul 13, 2020

Uh oh!

dcbw commented Jul 13, 2020

Uh oh!

openshift-ci-robot commented Jul 13, 2020

Uh oh!

dcbw commented Jul 13, 2020

Uh oh!

openshift-ci-robot commented Jul 13, 2020

Uh oh!

openshift-bot commented Jul 13, 2020

Uh oh!

openshift-ci-robot commented Jul 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants