Skip to content

OCPBUGS-42265: Fix the rails template before the upstream accepts or PR#574

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
metlos:manual-fix-of-rails
Sep 20, 2024
Merged

OCPBUGS-42265: Fix the rails template before the upstream accepts or PR#574
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
metlos:manual-fix-of-rails

Conversation

@metlos
Copy link
Copy Markdown
Contributor

@metlos metlos commented Sep 20, 2024

Fix the rails template before the upstream accepts our PR (sclorg/rails-ex#178).

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@metlos
Copy link
Copy Markdown
Contributor Author

metlos commented Sep 20, 2024

/test

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2024

@metlos: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-aws-operator
  • /test e2e-aws-ovn-builds
  • /test e2e-aws-ovn-image-ecosystem
  • /test e2e-aws-ovn-jenkins
  • /test e2e-aws-ovn-upgrade
  • /test images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test e2e-aws-ovn-proxy
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-samples-operator-master-e2e-aws
  • pull-ci-openshift-cluster-samples-operator-master-e2e-aws-operator
  • pull-ci-openshift-cluster-samples-operator-master-e2e-aws-ovn-image-ecosystem
  • pull-ci-openshift-cluster-samples-operator-master-e2e-aws-ovn-proxy
  • pull-ci-openshift-cluster-samples-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-samples-operator-master-images
  • pull-ci-openshift-cluster-samples-operator-master-unit
  • pull-ci-openshift-cluster-samples-operator-master-verify
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metlos
Copy link
Copy Markdown
Contributor Author

metlos commented Sep 20, 2024

/test all

@metlos metlos changed the title Fix the rails template before the upstream accepts or PR OCPBUGS-42265: Fix the rails template before the upstream accepts or PR Sep 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 20, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@metlos: This pull request references Jira Issue OCPBUGS-42265, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jitendar-singh

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fix the rails template before the upstream accepts our PR (sclorg/rails-ex#178).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fbm3307
Copy link
Copy Markdown
Contributor

fbm3307 commented Sep 20, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, metlos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD e756911 and 2 for PR HEAD cccebd3 in total

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD e756911 and 2 for PR HEAD cccebd3 in total

@metlos
Copy link
Copy Markdown
Contributor Author

metlos commented Sep 20, 2024

I am going to override the image ecosystem test so that our changes in openshift/origin#29116 have a chance to pass.

Currently we're in a Head-22 situation with these PRs.

The image ecosystem test in this PR uses the master of CI in openshift/origin that looks for a DeploymentConfig in Rails and uses perl:5.30-el7 for the Perl test. This won't pass because Rails now uses Deployment and per:5.30-el7 is not available anymore.

On the other hand, openshift/origin#29116 will not pass until we fix the rails templates in this PR.

@metlos
Copy link
Copy Markdown
Contributor Author

metlos commented Sep 20, 2024

/override ci/prow/e2e-aws-ovn-image-ecosystem

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2024

@metlos: Overrode contexts on behalf of metlos: ci/prow/e2e-aws-ovn-image-ecosystem

Details

In response to this:

/override ci/prow/e2e-aws-ovn-image-ecosystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2024

@metlos: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 21a101b into openshift:master Sep 20, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@metlos: Jira Issue OCPBUGS-42265: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42265 has been moved to the MODIFIED state.

Details

In response to this:

Fix the rails template before the upstream accepts our PR (sclorg/rails-ex#178).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-samples-operator
This PR has been included in build ose-cluster-samples-operator-container-v4.18.0-202409202309.p0.g21a101b.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants