OCPBUGS-42191: Fix image ecosystem tests#29116
OCPBUGS-42191: Fix image ecosystem tests#29116openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@metlos: This pull request references Jira Issue OCPBUGS-42191, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@metlos: This pull request references Jira Issue OCPBUGS-42191, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
requested review from
coreydaley,
deads2k and
jitendar-singh
|
/assign @adambkaplan |
|
/lgtm |
|
/test unit |
|
@metlos: This pull request references Jira Issue OCPBUGS-42191, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@phracek, based on the question of @adambkaplan from #29096 (review), could you please confirm that the smoke tests of the perl image performed in this PR are still sufficient? To summarize what the PR did previously and how it was simplified: Previously, our test built a custom image from the perl:5.30-el7 image and a custom app that opens some http endpoint and we checked that it returns the expected data in the http response. Then we also tested that hot-deploy is off by default by trying to modify the filesystem directly in the container and expecting the http response not to change. Afterwards we restarted the image with PERL_APACHE2_RELOAD=true and repeated the above procedure, now ensuring that hot deploy is switched on and directly modifying the filesystem of the container causes Perl to hot-reload the app and return a new http response. Because perl:5.30-el7 has been removed, we need to upgrade the test to the next "oldest" image available that I believe is perl:5.32-ubi8. By looking at https://github.com/sclorg/s2i-perl-container/tree/master/5.32 I found that the env var to switch hot-deploy has disappeared from the image and that hot deploy is on by default. Therefore I merely removed the part of the test that tests hot-reload switched off. In your opinion, is testing the perl image using a custom webapp and checking that it a) returns expected data as an http response and b) that hot-deploy works in the image, enough as a smoke test? |
|
/test e2e-gcp-ovn-image-ecosystem |
|
/retest-required |
|
Tests of the hot deploy are on the Perl container side too. The app is in https://github.com/sclorg/s2i-perl-container/tree/master/test/psgi-hot_deploy |
|
@adambkaplan to answer your question, as @michal-josef-spacek confirmed, the hot deploy is tested on the container so I don't think it is critical for us to also have that. That said, I think we should upgrade our testing Perl template to a more modern version similar to the one @michal-josef-spacek linked. I created https://issues.redhat.com/browse/SO-133 to track that but IMHO that is not necessary to do right now and can wait for until after the release of OCP 4.17. |
|
/retest-required |
|
/test e2e-gcp-ovn-image-ecosystem |
1 similar comment
|
/test e2e-gcp-ovn-image-ecosystem |
|
/test e2e-gcp-ovn-image-ecosystem let's try again, this time it was only a timeout while building the app image. |
|
/retest-required |
|
Job Failure Risk Analysis for sha: 01239a2
|
|
Job Failure Risk Analysis for sha: 01239a2
|
|
/override ci/prow/e2e-gcp-ovn-builds Known issue https://issues.redhat.com/browse/OCPBUGS-42237 |
|
@adambkaplan: adambkaplan unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Job Failure Risk Analysis for sha: 01239a2
|
Is there an ETA on the fix for that one? It's holding up everyone in origin we usually prefer to get the fix in before anything else instead of chasing overrides |
|
Job Failure Risk Analysis for sha: 01239a2
|
|
/override ci/prow/e2e-gcp-ovn-builds |
|
@sosiouxme: Overrode contexts on behalf of sosiouxme: ci/prow/e2e-gcp-ovn-builds DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
overriding based on the need to backport to 4.17 |
|
Job Failure Risk Analysis for sha: 01239a2
|
|
/skip |
|
@metlos: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 01239a2
|
1 similar comment
|
Job Failure Risk Analysis for sha: 01239a2
|
1 similar comment
|
/override ci/prow/e2e-gcp-ovn-builds |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-gcp-ovn-builds DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@metlos: Jira Issue OCPBUGS-42191: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-42191 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
9 participants
This merges the two pre-existing PRs #29096 and #29097 together so that we can get a passing image ecosystem CI job.