OCPBUGS-39373: Redo the PR #29082#29096
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@metlos: This pull request references Jira Issue OCPBUGS-39373, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test ci/prow/e2e-aws-ovn-image-ecosystem |
|
@metlos: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-gcp-ovn-image-ecosystem |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@metlos: This pull request references Jira Issue OCPBUGS-39373, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-gcp-ovn-image-ecosystem |
|
Note that |
|
/lgtm |
|
/retest |
|
/retest |
|
/test e2e-gcp-ovn-image-ecosystem |
|
/retest |
|
Job Failure Risk Analysis for sha: e6b215e
|
|
/test e2e-gcp-ovn-image-ecosystem |
metlos
changed the title
|
@metlos: This pull request references Jira Issue OCPBUGS-39373, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
Job Failure Risk Analysis for sha: 75569a5
|
|
/lgtm |
|
/assign stbenjam |
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
Please squash your commits, and ensure the commit has a well formatted title and description. Include the reasoning for deleting the hotfix portion of the test.
Is there someone from the RHEL team who can verify that this test is a sufficient "smoke test" for the perl s2i image?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ausil, fbm3307, metlos The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Because perl:5.32 image no longer supports the PERL_APACHE2_RELOAD env var, the portion of the test that tests the ability to switch off hot-deploy has been removed.
metlos
force-pushed
the
fix-missed-perl-version-updates
branch
from
75569a5 to
6089c60
Compare
|
New changes are detected. LGTM label has been removed. |
|
@phracek, would you be able to comment on whether the smoke test that we perform is sufficient? Or if not, would you be able to recommend someone that could? Previously, our test built a custom image from the Afterwards we restarted the image with Because By looking at https://github.com/sclorg/s2i-perl-container/tree/master/5.32 I found that the env var to switch hot-deploy has disappeared from the image and that hot deploy is on by default. Therefore I merely removed the part of the test that tests hot-reload switched off. In your opinion, is testing the perl image using a custom webapp and checking that it a) returns expected data as an http response and b) that hot-deploy works in the image, enough as a smoke test? |
|
/test e2e-gcp-ovn-image-ecosystem |
|
/retest |
|
@metlos: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 6089c60
|
|
I'm closing this in favor of #29116. |
|
@metlos: This pull request references Jira Issue OCPBUGS-39373. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7 participants
Turns out the fix in PR #29082 was not correct and wouldn't have been sufficient even if it were.
This PR fixes the Perl test and updates it to work with the new
perl:5.32-ubi8image that has different defaults and settings available (notice the disappearance ofPERL_APACHE2_RELOADenv var setting in https://github.com/sclorg/s2i-perl-container/tree/master/5.32 vs https://github.com/sclorg/s2i-perl-container/tree/master/5.30).