OCPBUGS-42336: Fix image ecosystem tests 4.17 by metlos · Pull Request #29126 · openshift/origin

metlos · 2024-09-23T22:06:17Z

This is a cherry-pick of #29116 and #28965 to the release-4.17 branch.

Because perl:5.32 image no longer supports the PERL_APACHE2_RELOAD env var, the portion of the test that tests the ability to switch off hot-deploy has been removed.

Deployments instead of DeploymentConfigs. This should enable us using either the old templates in 4.16 stream that use DeploymentConfigs and the new templates in 4.17+ that use Deployments.

openshift-ci-robot · 2024-09-23T22:09:05Z

@metlos: This pull request references Jira Issue OCPBUGS-42336, which is invalid:

expected dependent Jira Issue OCPBUGS-42191 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a cherry-pick of #29116 to the release-4.17 branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

… available in the library (openshift#28965) * Sync the list of tests for s2i images with the image versions available in the library. * Update the generated annotations. * comment out the image versions that seem to be unreleased. * update the generated code again

metlos · 2024-09-25T18:44:43Z

/jira refresh

openshift-ci-robot · 2024-09-25T18:44:49Z

@metlos: This pull request references Jira Issue OCPBUGS-42336, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.17.0) matches configured target version for branch (4.17.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-42191 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-42191 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
bug has dependents

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

metlos · 2024-09-26T08:23:44Z

/retest

metlos · 2024-09-26T08:40:14Z

/test e2e-gcp-ovn-builds

metlos · 2024-09-26T11:30:10Z

We are here in the same situation as in #29116 now. e2e-gcp-ovn-image-ecosystem is passing but e2e-gcp-ovn-builds fails because of the known reasons (see #29116 (comment)). Can I ask for the /override e2e-gcp-ovn-builds on this PR as well, so that we have at least passing image-ecosystem tests for the updated imagestreams and samples?

dgoodwin · 2024-09-26T14:05:53Z

/override ci/prow/e2e-gcp-ovn-builds

openshift-ci · 2024-09-26T14:06:01Z

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-gcp-ovn-builds

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2024-09-26T14:06:03Z

@metlos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade	`2c9b256`	link	false	`/test e2e-azure-ovn-upgrade`
ci/prow/e2e-gcp-ovn-builds	`2c9b256`	link	true	`/test e2e-gcp-ovn-builds`
ci/prow/e2e-aws-ovn-kube-apiserver-rollout	`2c9b256`	link	false	`/test e2e-aws-ovn-kube-apiserver-rollout`
ci/prow/e2e-aws-ovn-ipsec-serial	`2c9b256`	link	false	`/test e2e-aws-ovn-ipsec-serial`
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	`2c9b256`	link	false	`/test e2e-vsphere-ovn-dualstack-primaryv6`
ci/prow/e2e-aws-ovn-single-node-upgrade	`2c9b256`	link	false	`/test e2e-aws-ovn-single-node-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

metlos · 2024-09-26T14:45:46Z

@stbenjam, @deads2k could I get an approval and lgtm on this? As the title says, this is a cherry-pick of #29116 and #28965 to the release-4.17 branch.

sosiouxme

/lgtm

openshift-ci · 2024-09-26T15:06:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metlos, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sosiouxme]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

metlos · 2024-09-26T15:42:19Z

/label backport-risk-assessed

openshift-ci · 2024-09-26T15:42:45Z

@metlos: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

stbenjam · 2024-09-26T15:46:20Z

/label backport-risk-assessed
/label cherry-pick-approved

openshift-ci-robot · 2024-09-26T16:03:32Z

@metlos: Jira Issue OCPBUGS-42336: All pull requests linked via external trackers have merged:

openshift/origin#29126

Jira Issue OCPBUGS-42336 has been moved to the MODIFIED state.

Details

In response to this:

This is a cherry-pick of #29116 and #28965 to the release-4.17 branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-09-26T17:45:24Z

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.17.0-202409261706.p0.g2ee024f.assembly.stream.el9.
All builds following this will include this PR.

metlos added 2 commits September 24, 2024 00:02

Update the Perl image to the oldest one available in the image stream.

cfe594f

Because perl:5.32 image no longer supports the PERL_APACHE2_RELOAD env var, the portion of the test that tests the ability to switch off hot-deploy has been removed.

Re-enable the s2i rails test and update it to also support samples with

c718357

Deployments instead of DeploymentConfigs. This should enable us using either the old templates in 4.16 stream that use DeploymentConfigs and the new templates in 4.17+ that use Deployments.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 23, 2024

metlos mentioned this pull request Sep 25, 2024

OCPBUGS-39120: Sync the non-OKD assets from master to release-4.17 openshift/cluster-samples-operator#577

Merged

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 25, 2024

openshift-ci Bot requested a review from jitendar-singh September 25, 2024 18:44

sosiouxme approved these changes Sep 26, 2024

View reviewed changes

openshift-ci Bot assigned sosiouxme Sep 26, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024

openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Sep 26, 2024

openshift-ci Bot assigned adambkaplan Sep 26, 2024

openshift-ci Bot assigned dgoodwin, gangwgr, jadhaj, jitendar-singh, kasturinarra, pamoedom, prietyc123 and sayan-biswas Sep 26, 2024

Prashanth684 added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Sep 26, 2024

openshift-merge-bot Bot merged commit 2ee024f into openshift:release-4.17 Sep 26, 2024

Conversation

metlos commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 23, 2024

Uh oh!

metlos commented Sep 25, 2024

Uh oh!

openshift-ci-robot commented Sep 25, 2024

Uh oh!

metlos commented Sep 26, 2024

Uh oh!

metlos commented Sep 26, 2024

Uh oh!

metlos commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dgoodwin commented Sep 26, 2024

Uh oh!

openshift-ci Bot commented Sep 26, 2024

Uh oh!

openshift-ci Bot commented Sep 26, 2024

Uh oh!

metlos commented Sep 26, 2024

Uh oh!

sosiouxme left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Sep 26, 2024

Uh oh!

metlos commented Sep 26, 2024

Uh oh!

openshift-ci Bot commented Sep 26, 2024

Uh oh!

stbenjam commented Sep 26, 2024

Uh oh!

openshift-ci-robot commented Sep 26, 2024

Uh oh!

openshift-bot commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

metlos commented Sep 23, 2024 •

edited

Loading

metlos commented Sep 26, 2024 •

edited

Loading