Skip to content

SO-126: Sync the list of tests for s2i images with the image versions available in the library#28965

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
metlos:sync-s2i-image-tests
Aug 15, 2024
Merged

SO-126: Sync the list of tests for s2i images with the image versions available in the library#28965
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
metlos:sync-s2i-image-tests

Conversation

@metlos
Copy link
Copy Markdown
Contributor

@metlos metlos commented Aug 1, 2024 •
edited
Loading

Syncing the list of the image stream tests with the actual imagestreams defined in the library. This is in preparation for the release of Samples Operator for OCP 4.17.

Release JIRA: https://issues.redhat.com/projects/SO/issues/SO-123
JIRA for this task: https://issues.redhat.com/projects/SO/issues/SO-126

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 1, 2024

Hi @metlos. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested review from JoelSpeed and coreydaley August 1, 2024 08:50
@fbm3307
Copy link
Copy Markdown
Contributor

fbm3307 commented Aug 1, 2024

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2024
@metlos
Copy link
Copy Markdown
Contributor Author

metlos commented Aug 2, 2024

/retest-required

@metlos metlos changed the title Sync the list of tests for s2i images with the image versions available in the library SO-126: Sync the list of tests for s2i images with the image versions available in the library Aug 6, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 6, 2024 •
edited by openshift-ci Bot
Loading

@metlos: This pull request references SO-126 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Syncing the list of the image stream tests with the actual imagestreams defined in the library. This is in preparation for the release of Samples Operator for OCP 4.17.

Release JIRA: https://issues.redhat.com/projects/SO/issues/SO-123
JIRA for this task: https://issues.redhat.com/projects/SO/issues/SO-126

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2024
@metlos
Copy link
Copy Markdown
Contributor Author

metlos commented Aug 6, 2024

@soltysh, can I ask for a review and eventual merge of this?

soltysh
soltysh approved these changes Aug 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/label tide/merge-method-squash

@metlos get someone from your team to lgtm the PR

@openshift-ci openshift-ci Bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 7, 2024
@mfrancisc
Copy link
Copy Markdown

mfrancisc commented Aug 7, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metlos, mfrancisc, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metlos
Copy link
Copy Markdown
Contributor Author

metlos commented Aug 8, 2024

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 8, 2024

/retest-required

Remaining retests: 0 against base HEAD 56c3413 and 2 for PR HEAD 85f2c49 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 8, 2024

/retest-required

Remaining retests: 0 against base HEAD 55f41c0 and 1 for PR HEAD 85f2c49 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 8, 2024

/retest-required

Remaining retests: 0 against base HEAD d76b75c and 0 for PR HEAD 85f2c49 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 9, 2024

/hold

Revision 85f2c49 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2024
@openshift-trt-bot
Copy link
Copy Markdown

openshift-trt-bot commented Aug 9, 2024

Job Failure Risk Analysis for sha: 85f2c49

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-serial High
[sig-arch][Late] clients should not use APIs that are removed in upcoming releases [apigroup:apiserver.openshift.io] [Suite:openshift/conformance/parallel]
This test has passed 98.46% of 65 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-serial'] in the last 14 days.

Open Bugs
Removed APIs are still used in some test environment

@metlos
Copy link
Copy Markdown
Contributor Author

metlos commented Aug 15, 2024

/retest

@metlos
Copy link
Copy Markdown
Contributor Author

metlos commented Aug 15, 2024

/remove-hold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2024

@metlos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-ipsec-serial 85f2c49 link false /test e2e-aws-ovn-ipsec-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit f6bbda9 into openshift:master Aug 15, 2024
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 15, 2024

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202408152012.p0.gf6bbda9.assembly.stream.el9.
All builds following this will include this PR.

jubittajohn pushed a commit to jubittajohn/origin that referenced this pull request Aug 21, 2024
@metlos @jubittajohn
SO-126: Sync the list of tests for s2i images with the image versions…
17ebc1f 
… available in the library (openshift#28965)

* Sync the list of tests for s2i images with the image versions available in
the library.

* Update the generated annotations.

* comment out the image versions that seem to be unreleased.

* update the generated code again
metlos added a commit to metlos/origin that referenced this pull request Sep 25, 2024
@metlos
SO-126: Sync the list of tests for s2i images with the image versions…
2c9b256 
… available in the library (openshift#28965)

* Sync the list of tests for s2i images with the image versions available in
the library.

* Update the generated annotations.

* comment out the image versions that seem to be unreleased.

* update the generated code again
@metlos metlos mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coreydaley coreydaley Awaiting requested review from coreydaley

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mfrancisc mfrancisc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@metlos @fbm3307 @openshift-ci-robot @mfrancisc @openshift-trt-bot @openshift-bot @soltysh