Skip to content

Conversation

@paulfantom
Copy link
Contributor

Follow-up to #234

Without this label prometheus-operator doesn't watch openshift-cluster-version namespace in search for ServiceMonitor.

/assign @abhinavdahiya
/cc @s-urbaniak

@openshift-ci-robot
Copy link
Contributor

@paulfantom: GitHub didn't allow me to request PR reviews from the following users: s-urbaniak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Follow-up to #234

Without this label prometheus-operator doesn't watch openshift-cluster-version namespace in search for ServiceMonitor.

/assign @abhinavdahiya
/cc @s-urbaniak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2019
@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

@s-urbaniak: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2019
@abhinavdahiya
Copy link
Contributor

[Feature:Prometheus][Conformance] Prometheus when installed on the cluster should report less than two alerts in firing or pending state [Suite:openshift/conformance/parallel/minimal] seems to be consistently failing.

Also can you attach this to a bug, please.

@paulfantom paulfantom changed the title install: enable prometheus-operator to watch over namespace in search for ServiceMonitor Bug 1738527: install: enable prometheus-operator to watch over namespace in search for ServiceMonitor Aug 15, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 15, 2019
@openshift-ci-robot
Copy link
Contributor

@paulfantom: This pull request references an invalid Bugzilla bug:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1738527: install: enable prometheus-operator to watch over namespace in search for ServiceMonitor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom
Copy link
Contributor Author

paulfantom commented Aug 15, 2019

This is a follow-up to #234.

I have started a cluster from this PR and failing test is due to PrometheusDuplicateTimestamps alert. This means CVO metrics endpoint registered in this PR is working, but we need to:

  1. temporarily rewrite that test
  2. merge this PR
  3. merge Remove CVO service monitor cluster-monitoring-operator#390

@paulfantom
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 15, 2019
@openshift-ci-robot
Copy link
Contributor

@paulfantom: This pull request references a valid Bugzilla bug. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom
Copy link
Contributor Author

It seems that with this PR both metrics endpoints are active:

Test changes are on the way: openshift/origin#23605

@paulfantom
Copy link
Contributor Author

Test is modified.

/retest

@paulfantom
Copy link
Contributor Author

Apparently test wasn't picked up yet and last CI run was with previous tests.

/test e2e-aws

@paulfantom
Copy link
Contributor Author

@abhinavdahiya if this looks ok, can we have /lgtm and let bot do its job of retesting and finally merging it?

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, paulfantom, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 84c6d3c into openshift:master Aug 15, 2019
@openshift-ci-robot
Copy link
Contributor

@paulfantom: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

Details

In response to this:

Bug 1738527: install: enable prometheus-operator to watch over namespace in search for ServiceMonitor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom paulfantom deleted the enable_monitoring_on_namespace branch August 15, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants