-
Notifications
You must be signed in to change notification settings - Fork 216
Bug 1738527: install: enable prometheus-operator to watch over namespace in search for ServiceMonitor #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1738527: install: enable prometheus-operator to watch over namespace in search for ServiceMonitor #235
Conversation
… for ServiceMonitor
|
@paulfantom: GitHub didn't allow me to request PR reviews from the following users: s-urbaniak. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@s-urbaniak: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/approve |
|
Also can you attach this to a bug, please. |
|
@paulfantom: This pull request references an invalid Bugzilla bug:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This is a follow-up to #234. I have started a cluster from this PR and failing test is due to
|
|
/bugzilla refresh |
|
@paulfantom: This pull request references a valid Bugzilla bug. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
It seems that with this PR both metrics endpoints are active:
Test changes are on the way: openshift/origin#23605 |
|
Test is modified. /retest |
|
Apparently test wasn't picked up yet and last CI run was with previous tests. /test e2e-aws |
|
@abhinavdahiya if this looks ok, can we have |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, paulfantom, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@paulfantom: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |


Follow-up to #234
Without this label prometheus-operator doesn't watch
openshift-cluster-versionnamespace in search for ServiceMonitor./assign @abhinavdahiya
/cc @s-urbaniak