Bug 1741645: pkg/cvo/metrics: Report cluster-version conditions with reasons

[wking]

This will allow us to discover upgrade and other failure reasons without having to resort to a must-gather or similar.

Stick this in cluster_operator_conditions, since we already have a reason slot there. I don't see a reason to add a new metric to separate cluster-version operator failures from second-level operator failures; the name should be sufficient for that.

[wking]

This may overlap with #232 as a way to get ClusterVersion failure reasons out into Telemetry. Are the parallel tracks (alerts and cluster_operator_conditions metrics) a problem? Do we want to consolidate on alerts and drop cluster_operator_conditions altogether? Or do we want both for a belt-and-suspenders approach, or just because each channel gives us slightly different information (e.g. cluster_operator_conditions may make it easier to get failure rates, because we still push the metrics, with a zero value, when the condition is not active).

[abhinavdahiya]

we should also create a bug for this.

[wking]

/retitle Bug 1741645: pkg/cvo/metrics: Report cluster-version conditions with reasons

[openshift-ci-robot]

@wking: This pull request references an invalid Bugzilla bug:

• expected the bug to target the "4.2.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1741645: pkg/cvo/metrics: Report cluster-version conditions with reasons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

/bugzilla refresh

[openshift-ci-robot]

@wking: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[abhinavdahiya]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wking]

e2e-aws:

level=error msg="Error: NoSuchBucket: The specified bucket does not exist"
level=error msg="\tstatus code: 404, request id: CE2EC2492682F231, host id: Hzp7AoarEa//ZVR8XEoblAxIFZ2A8AipR3lyGzeCjGxO69/oSHeCNZap3tbF2g/T+mdcd/xmEzo="

Haven't seen that one recently...

/test e2e-aws

[wking]

e2e-aws:

Aug 15 20:25:46.283: INFO: Couldn't delete ns: "e2e-svcaccounts-2403": namespace e2e-svcaccounts-2403 was not deleted with limit: timed out waiting for the condition, namespace is empty but is not yet removed (&errors.errorString{s:"namespace e2e-svcaccounts-2403 was not deleted with limit: timed out waiting for the condition, namespace is empty but is not yet removed"}) 

That's rhbz#1727090.

/test e2e-aws

[openshift-ci-robot]

@wking: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

Details

In response to this:

Bug 1741645: pkg/cvo/metrics: Report cluster-version conditions with reasons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

/cherrypick release-4.1

[openshift-cherrypick-robot]

@wking: new pull request created: #237

Details

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.