Skip to content

Bug 1741661: pkg/cvo/metrics: Report cluster-version conditions with reasons #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 20, 2019
Merged

Bug 1741661: pkg/cvo/metrics: Report cluster-version conditions with reasons #237

openshift-merge-robot merged 1 commit into from
Aug 20, 2019

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Aug 15, 2019

This is an automated cherry-pick of #236

/assign wking

@wking
pkg/cvo/metrics: Report ClusterVersion conditions with reasons
8fc0631 
This will allow us to discover upgrade and other failure reasons
without having to resort to a must-gather or similar [1].  And also to
look at any other version conditions in Telemetry.

Stick this in cluster_operator_conditions, since we already have a
'reason' slot there.  And ClusterVersion.Status.Conditions is pretty
much the same thing as ClusterOperator.Status.Conditions; we'll want
to see all of those.  I don't see a reason to add a new metric to
separate cluster-version operator failures from second-level operator
failures; the name should be sufficient for that.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1741645
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 15, 2019
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 15, 2019

@openshift-cherrypick-robot: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.1] Bug 1741645: pkg/cvo/metrics: Report cluster-version conditions with reasons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 15, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 15, 2019
@wking wking changed the title [release-4.1] Bug 1741645: pkg/cvo/metrics: Report cluster-version conditions with reasons Bug 1741661: pkg/cvo/metrics: Report cluster-version conditions with reasons Aug 15, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 15, 2019

@openshift-cherrypick-robot: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1741661: pkg/cvo/metrics: Report cluster-version conditions with reasons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Aug 15, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 15, 2019

@wking: This pull request references an invalid Bugzilla bug:

  • expected the bug to target the "4.1.z" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Aug 15, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 15, 2019

@wking: This pull request references an invalid Bugzilla bug:

  • expected dependent Bugzilla bug to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Aug 19, 2019

4.2 bug verified, which should unblock this backport.

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 19, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2019

@wking: This pull request references Bugzilla bug 1741661, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

4.2 bug verified, which should unblock this backport.

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Aug 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2019
@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 20, 2019
@openshift-merge-robot openshift-merge-robot merged commit d68729c into openshift:release-4.1 Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2019

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1741661 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1741661: pkg/cvo/metrics: Report cluster-version conditions with reasons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wking wking Awaiting requested review from wking

Assignees

@wking wking

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @openshift-ci-robot @wking @abhinavdahiya @eparis @openshift-merge-robot