Skip to content

genric_handler: error when object has no name #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 10, 2018
Merged

genric_handler: error when object has no name #33

openshift-merge-robot merged 1 commit into from
Oct 10, 2018

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Oct 5, 2018

fixes #32
/cc @wking

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2018
wking
wking reviewed Oct 5, 2018
View reviewed changes
pkg/cvo/internal/generic.go

func applyUnstructured(client dynamic.ResourceInterface, required *unstructured.Unstructured) (*unstructured.Unstructured, bool, error) {
if required.GetName() == "" {
return nil, false, fmt.Errorf("invalid object: name cannot be empty")
Copy link
Member

@wking wking Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm. Is there some way we can get an identifier here to help the log-reader figure out what needs fixing? Ordinarily that would be the name, but in this case... ? Maybe push this up into genericBuilder.Do where we can dump the broken b.raw?

Copy link
Member

@wking wking Oct 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe keep more information (like the GVK?) from the initial m lib.Manifest in NewGenericBuilder?

Copy link
Contributor Author

@abhinavdahiya abhinavdahiya Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster-version-operator/pkg/cvo/sync.go

Line 51 in 4356101

if err := b.Do(); err != nil {

We print out the details of the task.

@wking
Copy link
Member

wking commented Oct 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2018
@wking wking mentioned this pull request Oct 7, 2018
Closed
@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 9, 2018

/test e2e-aws

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2018
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2018
@abhinavdahiya abhinavdahiya reopened this Oct 10, 2018
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2018
@crawford
Copy link
Contributor

crawford commented Oct 10, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2018
@openshift-merge-robot openshift-merge-robot merged commit 26de3dc into openshift:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking left review comments

Assignees

@wking wking

@crawford crawford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

a5a76d5 panic: interface conversion: runtime.Object is *unstructured.UnstructuredList, not *unstructured.Unstructured [recovered]

6 participants

@abhinavdahiya @wking @smarterclayton @crawford @openshift-ci-robot @openshift-merge-robot