Skip to content

genric_handler: error when object has no name #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Oct 10, 2018
Merged

genric_handler: error when object has no name #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/cvo/internal/generic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package internal

import (
"encoding/json"
"fmt"

apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand All @@ -28,6 +29,9 @@ func readUnstructuredV1OrDie(objBytes []byte) *unstructured.Unstructured {
}

func applyUnstructured(client dynamic.ResourceInterface, required *unstructured.Unstructured) (*unstructured.Unstructured, bool, error) {
if required.GetName() == "" {
return nil, false, fmt.Errorf("invalid object: name cannot be empty")
Copy link
Member

@wking wking Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm. Is there some way we can get an identifier here to help the log-reader figure out what needs fixing? Ordinarily that would be the name, but in this case... ? Maybe push this up into genericBuilder.Do where we can dump the broken b.raw?

Copy link
Member

@wking wking Oct 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe keep more information (like the GVK?) from the initial m lib.Manifest in NewGenericBuilder?

Copy link
Contributor Author

@abhinavdahiya abhinavdahiya Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cluster-version-operator/pkg/cvo/sync.go

Line 51 in 4356101

if err := b.Do(); err != nil {

We print out the details of the task.

}
existing, err := client.Get(required.GetName(), metav1.GetOptions{})
if apierrors.IsNotFound(err) {
actual, err := client.Create(required)
Expand Down