Skip to content

metrics: Default metrics port conflicts with node-exporter#56

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
smarterclayton:port
Nov 20, 2018
Merged

metrics: Default metrics port conflicts with node-exporter#56
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
smarterclayton:port

Conversation

@smarterclayton
Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton commented Nov 20, 2018

Change to 9099, I will create a document in openshift/origin to track
claimed ports.

@smarterclayton
metrics: Default metrics port conflicts with node-exporter
0bb98c9 
Change to 9099, I will create a document in openshift/origin to track
claimed ports.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2018
@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Nov 20, 2018

I will create a document in openshift/origin to track claimed ports.
that would be super helpful.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2018
s-urbaniak
s-urbaniak approved these changes Nov 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, s-urbaniak, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 20, 2018

@s-urbaniak: changing LGTM is restricted to assignees, and only openshift/cluster-version-operator repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 10d0edb into openshift:master Nov 20, 2018
@smarterclayton
Copy link
Copy Markdown
Contributor Author

smarterclayton commented Nov 20, 2018

Documented openshift/origin#21520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@crawford crawford Awaiting requested review from crawford

1 more reviewer

@s-urbaniak s-urbaniak s-urbaniak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smarterclayton @abhinavdahiya @openshift-ci-robot @s-urbaniak @openshift-merge-robot