Skip to content

Document reserved ports#21520

Closed
smarterclayton wants to merge 1 commit intoopenshift:masterfrom
smarterclayton:doc
Closed

Document reserved ports#21520
smarterclayton wants to merge 1 commit intoopenshift:masterfrom
smarterclayton:doc

Conversation

@smarterclayton
Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton commented Nov 20, 2018

No description provided.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2018
This was referenced Nov 20, 2018
Merged
Merged
Merged
abhinavdahiya
abhinavdahiya reviewed Nov 20, 2018
View reviewed changes
Comment thread docs/ports.md Outdated
wking
wking reviewed Nov 20, 2018
View reviewed changes
Comment thread docs/ports.md
OpenShift Reserved Ports
========================

OpenShift reserves all ports on hosts that are reserved by [upstream Kubernetes](https://github.com/kubernetes/kubernetes/blob/master/pkg/master/ports/ports.go) as well as the following host ports:
Copy link
Copy Markdown
Member

@wking wking Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin this to a specific release? Kubernetes might decide to move that file, or they might decide to add or remove entries. Our implementation will match the state as it stood the last time we looked at that file. With a pinned link, it would be up to the reader to decide whether that still matched whatever was in Kubernetes current master or not (which they could probably do with git diff ...).

Copy link
Copy Markdown
Contributor Author

@smarterclayton smarterclayton Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. I'm wondering if we should have an e2e test that enforces this on the cluster (looks at all host network pods or host ports on the cluster and compares it). Then we don't need this doc.

Copy link
Copy Markdown
Contributor

@abhinavdahiya abhinavdahiya Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@squeed also mentioned having a conformance test for reserved ports.

Copy link
Copy Markdown
Contributor

@squeed squeed Nov 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I hacked up a conformance test yesterday (after giving up writing a SOCK_DIAG client and just shelling out to netstat, lol). However, it's not clear where it belongs, since it tests manifests that are supplied by descendant operators.

If it's useful, I can add it to openshift/origin.

Comment thread docs/ports.md

OpenShift reserves all ports on hosts that are reserved by [upstream Kubernetes](https://github.com/kubernetes/kubernetes/blob/master/pkg/master/ports/ports.go) as well as the following host ports:

| 2379,2380 | masters | [etcd](https://github.com/openshift/installer) | etcd API |
Copy link
Copy Markdown
Member

@wking wking Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add a space after the comma here to match your "Node Exporter" line below?

Also, do you mean to link the installer for "etcd"? I'd have expected a link to https://github.com/etcd-io/etcd#etcd-tcp-ports

Copy link
Copy Markdown
Contributor Author

@smarterclayton smarterclayton Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, although the installer / mcd controls where that goes. So I was linking to the relevant authority within our space.

Comment thread docs/ports.md
| 2379,2380 | masters | [etcd](https://github.com/openshift/installer) | etcd API |
| 6443 | masters |[kube-apiserver](https://github.com/openshift/cluster-kube-apiserver-operator) | Kubernetes API |
| 9099 | masters | [Cluster Version Operator](https://github.com/openshift/cluster-version-operator) | Metrics |
| 9100, 9101 | nodes | [Node Exporter](https://github.com/openshift/node_exporter) | Metrics |
Copy link
Copy Markdown
Member

@wking wking Nov 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "nodes" mean "workers" (a.k.a. "compute", etc.), or does it mean "all machines in the cluster, regardless of role"?

Copy link
Copy Markdown
Contributor Author

@smarterclayton smarterclayton Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All machines in the cluster. This could be more formal (as the mentioned e2e test)

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 15, 2019

@smarterclayton: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/cmd a42fdfe link /test cmd
ci/prow/integration a42fdfe link /test integration
ci/prow/e2e-gcp a42fdfe link /test e2e-gcp
ci/prow/e2e-aws a42fdfe link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Copy Markdown

kikisdeliveryservice commented Feb 15, 2019 •
edited
Loading

Hi @smarterclayton as per openshift/machine-config-operator#368 and openshift/installer#1180 could we add the machine-config-server port at 22623?

@abhinavdahiya abhinavdahiya mentioned this pull request Mar 1, 2019
Merged
@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Mar 1, 2019 •
edited
Loading

@smarterclayton approval request for port 23790 for metrics proxy https://github.com/openshift/installer/pull/1291/files. I used this as it is the default for grpc-proxy and similar to etcd client 2379 no strong feelings if you want to change.

sticking with 9979

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 3, 2019

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 3, 2019

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 3, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Aug 2, 2019

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 2, 2019

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

3 more reviewers

@wking wking wking left review comments

@squeed squeed squeed left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@smarterclayton @openshift-ci-robot @kikisdeliveryservice @hexfusion @openshift-bot @wking @squeed @abhinavdahiya