Skip to content

pkg/cvo: add test utility functions#833

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
jottofar:unit-tests
Sep 13, 2022
Merged

pkg/cvo: add test utility functions#833
openshift-merge-robot merged 2 commits into
openshift:masterfrom
jottofar:unit-tests

Conversation

@jottofar
Copy link
Copy Markdown
Contributor

@jottofar jottofar commented Sep 9, 2022

that allow checks of an entire structure or one of it's sub-structures (using generics). Also added is the ability to check for a single
status, e.g. the "final" status, by specifying a condition to indicate some state such as finality, e.g. Completed==3. There are also some functions that allow a test to wait for a particular condition, e.g. payload load status is "PayloadLoaded", before continuing.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2022
@openshift-ci openshift-ci Bot requested review from vrutkovs and wking September 9, 2022 18:30
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2022
@jottofar jottofar force-pushed the unit-tests branch 2 times, most recently from 2ad76e8 to ee8477e Compare September 9, 2022 20:48
@jottofar
Copy link
Copy Markdown
Contributor Author

/retest

@jottofar
Copy link
Copy Markdown
Contributor Author

/test e2e-agnostic-upgrade-into-change

@LalatenduMohanty
Copy link
Copy Markdown
Member

@jottofar the PR looks good to me except one nit pick, can you update the commit message d85b376 with steps about how you generated the files?

Steps:
- Changed go.mod to use 'go 1.18'
- go mod tidy
- go mod vendor
that allows checks of an entire structure or one of it's sub-structures
(using generics). Also added is the ability to check for a single
status, e.g. the "final" status, by specifying a condition to indicate
some state such as finality, e.g. Completed==3. There are also some
functions that allow a test to wait for a particular condition,
e.g. payload load status is "PayloadLoaded", before continuing.
Copy link
Copy Markdown
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jottofar, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,jottofar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jottofar
Copy link
Copy Markdown
Contributor Author

/retest

@jottofar
Copy link
Copy Markdown
Contributor Author

/test e2e-agnostic

@wking
Copy link
Copy Markdown
Member

wking commented Sep 13, 2022

@wking
Copy link
Copy Markdown
Member

wking commented Sep 13, 2022

Only failing Application behind service load balancer with PDB remains available using new connections is orthogonal:

/override ci/prow/e2e-agnostic-upgrade-into-change

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic

Details

In response to this:

Only failing Prometheus when installed on the cluster should report telemetry if a cloud.openshift.com token is present is orthogonal (described in openshift/release#32249):

/override ci/prow/e2e-agnostic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-into-change

Details

In response to this:

Only failing Application behind service load balancer with PDB remains available using new connections is orthogonal:

/override ci/prow/e2e-agnostic-upgrade-into-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 583c3e2 into openshift:master Sep 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

@jottofar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants