[CNF-5646] bump api version to add new capability by qJkee · Pull Request #835 · openshift/cluster-version-operator

qJkee · 2022-09-12T21:11:42Z

bump openshift/api with new capability

qJkee · 2022-09-13T15:09:17Z

/retest

wking · 2022-09-13T16:32:26Z

upgrade-out-of-change CI will never complete when dropping a cap from the CRD enum. That run got far enough to be running the target CVO, which is good enough for these changes.

/override ci/prow/e2e-agnostic-upgrade-out-of-change

openshift-ci · 2022-09-13T16:33:42Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

upgrade-out-of-change CI will never complete when dropping a cap from the CRD enum. That run got far enough to be running the target CVO, which is good enough for these changes.

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2022-09-14T08:15:10Z

Will need a rebase around the vendor bumps that just landed in #833.

wking · 2022-09-14T08:19:31Z

Also, before we land this, can we remove the draft status from openshift/cluster-csi-snapshot-controller-operator#126 to confirm that the pull request presubmits all pass with the annotated manifests removed? That's covered in step 3 of the onboarding docs, and helps protect against "oops, I guess CI fails with this capability removed, and we need to..." excitement before we commit to landing hard-to-revert changes in multiple repositories.

qJkee · 2022-09-15T15:40:35Z

/test e2e-agnostic-upgrade-into-change

gnufied · 2022-09-20T13:15:45Z

@qJkee can you update this bump again and pull from latest api and client-go repos? I have updated ClusterCSIDriver objects with new functionality and hence need the CVO to apply latest CRDs.

xref - openshift/api#1271

gnufied · 2022-09-20T13:15:54Z

/retest

qJkee · 2022-09-20T15:27:51Z

@gnufied
Yes, will do

qJkee · 2022-09-21T15:16:24Z

@wking
Does 2e-agnostic-upgrade-out-of-change still not working properly?

jsafrane · 2022-09-23T14:44:58Z

/retest

wking · 2022-09-23T17:50:01Z

e2e-agnostic-upgrade-out-of-change goes from your proposed state to the current base branch, so it drops a cap. That will always fail on:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cluster-version-operator/835/pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade-out-of-change/1572284562753458176/artifacts/e2e-agnostic-upgrade-out-of-change/gather-extra/artifacts/pods/openshift-cluster-version_cluster-version-operator-75f44b9fbb-gqx56_cluster-version-operator.log | grep 'ClusterVersion.config.openshift.io .* is invalid' | tail -n1
I0920 21:50:51.604571       1 cvo.go:550] Error handling openshift-cluster-version/version: ClusterVersion.config.openshift.io "version" is invalid: status.capabilities.enabledCapabilities[0]: Unsupported value: "CSISnapshot": supported values: "openshift-samples", "baremetal", "marketplace", "Console", "Insights", "Storage"

as the CVO tries to explain that CSISnapshot is enabled to an API-server that is looking at a CRD which no longer mentions CSISnapshot. The fact that the job got far enough to roll out the base-branch CRD and CVO is sufficient for this PR, and we can /override ... when we're ready to land.

wking

OCPBUGS-1904 isn't fixed yet. Dropping a cap from that validation enum breaks updates, but, but the bug is a 4.12 blocker now, which means we're committed to making this work, and won't have to revert the CSISnapshot enum entry.

/lgtm

openshift-ci-robot · 2022-10-05T17:49:12Z

/retest-required

Remaining retests: 0 against base HEAD 12677ae and 2 for PR HEAD 02553d2 in total

wking · 2022-10-05T18:38:20Z

Refreshing:

/override ci/prow/e2e-agnostic-upgrade-out-of-change

openshift-ci · 2022-10-05T18:38:44Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

Refreshing:

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qJkee · 2022-10-07T01:03:37Z

/retest

brandisher · 2022-10-07T13:17:58Z

/retest

wking · 2022-10-07T21:35:35Z

/override ci/prow/e2e-agnostic-upgrade-out-of-change

openshift-ci · 2022-10-07T21:35:49Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-10-08T00:46:19Z

/retest-required

Remaining retests: 0 against base HEAD 5ccadd5 and 2 for PR HEAD e027e7d in total

qJkee · 2022-10-10T10:55:39Z

/retest-required

qJkee · 2022-10-10T15:11:28Z

/test e2e-agnostic-upgrade-out-of-change

wking · 2022-10-10T17:18:37Z

This will never pass for cap addition; overriding again:

/override e2e-agnostic-upgrade-out-of-change

openshift-ci · 2022-10-10T17:19:09Z

@wking: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

e2e-agnostic-upgrade-out-of-change

Only the following failed contexts/checkruns were expected:

ci/prow/e2e-agnostic
ci/prow/e2e-agnostic-operator
ci/prow/e2e-agnostic-upgrade-into-change
ci/prow/e2e-agnostic-upgrade-out-of-change
ci/prow/gofmt
ci/prow/images
ci/prow/lint
ci/prow/unit
pull-ci-openshift-cluster-version-operator-master-e2e-agnostic
pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-operator
pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade-into-change
pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-upgrade-out-of-change
pull-ci-openshift-cluster-version-operator-master-gofmt
pull-ci-openshift-cluster-version-operator-master-images
pull-ci-openshift-cluster-version-operator-master-lint
pull-ci-openshift-cluster-version-operator-master-unit
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

This will never pass for cap addition; overriding again:

/override e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2022-10-10T17:26:17Z

/override ci/prow/e2e-agnostic-upgrade-out-of-change

openshift-ci · 2022-10-10T17:26:31Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qJkee · 2022-10-10T17:37:01Z

This will never pass for cap addition; overriding again:

/override e2e-agnostic-upgrade-out-of-change

ahh, I did not mention that. I thought it was another "good" job that started to fail, thank you!

openshift-ci-robot · 2022-10-10T19:25:38Z

/retest-required

Remaining retests: 0 against base HEAD bce1e9f and 1 for PR HEAD e027e7d in total

openshift-ci · 2022-10-10T20:15:38Z

@qJkee: qJkee unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight.

Details

In response to this:

since Trevor already done that, overriding the test
/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2022-10-10T20:17:43Z

/override ci/prow/e2e-agnostic-upgrade-out-of-change

openshift-ci · 2022-10-10T20:18:50Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2022-10-10T21:33:54Z

Network-y TargetDown and OAuth connectivity are orthogonal.

/override ci/prow/e2e-agnostic-upgrade-into-change

openshift-ci · 2022-10-10T21:34:17Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-into-change

Details

In response to this:

Network-y TargetDown and OAuth connectivity are orthogonal.

/override ci/prow/e2e-agnostic-upgrade-into-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

go get github.com/openshift/api@5eaf4250c423eb7ae6b3139d82c14f14e5fe804a go mod tidy go mod vendor git add -A go.* vendor

go get github.com/openshift/client-go@9dfefb19db2e6e1854c389b9e97a784752e2e41c go mod tidy go mod vendor git add -A go.* vendor

update tests with new capabilities brought by new version of openshift/api package

wking

/lgtm
/override ci/prow/e2e-agnostic-upgrade-out-of-change

openshift-ci · 2022-10-11T19:54:44Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

/lgtm
/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-10-11T19:56:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-10-11T23:59:23Z

@qJkee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-upgrade-out-of-change	`2fd7756`	link	unknown	`/test e2e-agnostic-upgrade-out-of-change`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci Bot requested review from jottofar and vrutkovs September 12, 2022 21:14

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2022

qJkee force-pushed the CNF-5646-bump-api branch from 899cd04 to 9a6d420 Compare September 14, 2022 17:18

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2022

qJkee force-pushed the CNF-5646-bump-api branch from 9a6d420 to 02553d2 Compare September 20, 2022 17:59

duanwei33 mentioned this pull request Sep 28, 2022

STOR-1050: bump openshift/api to latest master openshift/cluster-storage-operator#319

Merged

wking approved these changes Oct 5, 2022

View reviewed changes

openshift-ci Bot assigned wking Oct 5, 2022

openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 5, 2022

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022

qJkee force-pushed the CNF-5646-bump-api branch from be6d6c6 to e027e7d Compare October 6, 2022 18:07

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022

qJkee added 2 commits October 10, 2022 19:19

vendor: upgrade openshift/api

8e64353

go get github.com/openshift/api@5eaf4250c423eb7ae6b3139d82c14f14e5fe804a go mod tidy go mod vendor git add -A go.* vendor

vendor: upgrade openshift/client-go

c5b0894

go get github.com/openshift/client-go@9dfefb19db2e6e1854c389b9e97a784752e2e41c go mod tidy go mod vendor git add -A go.* vendor

qJkee force-pushed the CNF-5646-bump-api branch from e027e7d to 85ebc4b Compare October 10, 2022 23:19

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2022

update tests with new capabilities

2fd7756

update tests with new capabilities brought by new version of openshift/api package

qJkee force-pushed the CNF-5646-bump-api branch from 85ebc4b to 2fd7756 Compare October 11, 2022 15:27

wking approved these changes Oct 11, 2022

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022

openshift-merge-robot merged commit af4633b into openshift:master Oct 11, 2022

dagrayvid mentioned this pull request Jan 11, 2023

[PSAP-741] vendor: update openshift/api for NodeTuning capability #883

Merged

Conversation

qJkee commented Sep 12, 2022

Uh oh!

qJkee commented Sep 13, 2022

Uh oh!

wking commented Sep 13, 2022

Uh oh!

openshift-ci Bot commented Sep 13, 2022

Uh oh!

wking commented Sep 14, 2022

Uh oh!

wking commented Sep 14, 2022

Uh oh!

qJkee commented Sep 15, 2022

Uh oh!

gnufied commented Sep 20, 2022

Uh oh!

gnufied commented Sep 20, 2022

Uh oh!

qJkee commented Sep 20, 2022

Uh oh!

qJkee commented Sep 21, 2022

Uh oh!

jsafrane commented Sep 23, 2022

Uh oh!

wking commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 5, 2022

Uh oh!

wking commented Oct 5, 2022

Uh oh!

openshift-ci Bot commented Oct 5, 2022

Uh oh!

qJkee commented Oct 7, 2022

Uh oh!

brandisher commented Oct 7, 2022

Uh oh!

wking commented Oct 7, 2022

Uh oh!

openshift-ci Bot commented Oct 7, 2022

Uh oh!

openshift-ci-robot commented Oct 8, 2022

Uh oh!

qJkee commented Oct 10, 2022

Uh oh!

qJkee commented Oct 10, 2022

Uh oh!

wking commented Oct 10, 2022

Uh oh!

openshift-ci Bot commented Oct 10, 2022

Uh oh!

wking commented Oct 10, 2022

Uh oh!

openshift-ci Bot commented Oct 10, 2022

Uh oh!

qJkee commented Oct 10, 2022

Uh oh!

openshift-ci-robot commented Oct 10, 2022

Uh oh!

openshift-ci Bot commented Oct 10, 2022

Uh oh!

wking commented Oct 10, 2022

Uh oh!

openshift-ci Bot commented Oct 10, 2022

Uh oh!

wking commented Oct 10, 2022

Uh oh!

openshift-ci Bot commented Oct 10, 2022

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Oct 11, 2022

Uh oh!

openshift-ci Bot commented Oct 11, 2022

Uh oh!

wking commented Sep 23, 2022 •

edited

Loading