[PSAP-741] vendor: update openshift/api for NodeTuning capability

[dagrayvid]

This PR updates the openshift/api dependency version to bring in the new NodeTuning capability, and updates the unit tests to include this capability.

See PSAP-741 as well as the merged PR openshift/api#1373.

[petr-muller]

/retest

[dagrayvid]

/retest

[dagrayvid]

/retest

[petr-muller]

/hold

This is suspicious and should be investigated. The e2e-agnostic-upgrade-out-of-change job fails consistently (all four runs here) on the following. This does not happen on other PRs so it's somehow likely it's really caused by the change.

{Cluster did not complete upgrade: timed out waiting for the condition: Working towards 4.13.0-0.ci.test-2023-01-09-214219-ci-op-xsft9vl1-initial: 4 of 831 done (0% complete)  }

[petr-muller]

From CVO log:

I0111 18:40:47.628727       1 cvo.go:550] Error handling openshift-cluster-version/version: ClusterVersion.config.openshift.io "version" is invalid: status.capabilities.enabledCapabilities[3]: Unsupported value: "NodeTuning": supported values: "openshift-samples", "baremetal", "marketplace", "Console", "Insights", "Storage", "CSISnapshot"

[dagrayvid]

Thanks @petr-muller for digging into that. Looking at past PRs for capability addition, it seems like this will never pass.
cc @wking

[petr-muller]

Yeah that actually sounds plausible. We cannot upgrade from the CVO with the cap to CVO without it. Hopefully Trevor will confirm.

[wking]

I rounded with @dagrayvid out of band. Summarizing:

• These docs cover the intended new-capability onboarding flow.
• This pull request is step 5.
• Opening Make NTO components an optional OpenShift feature cluster-node-tuning-operator#524 is step 2.
• David's confirmed that Make NTO components an optional OpenShift feature cluster-node-tuning-operator#524 shows all the NTO bits removed, with no dangling resources (3.i).
• For component-is-not-installed CI (3.ii), this e2e-aws-ovn run on Make NTO components an optional OpenShift feature cluster-node-tuning-operator#524 shows oc explain should contain proper spec+status for CRDs failing on the server doesn't have a resource type "profiles". David will open an origin pull request touching here or similar to avoid that issue. Depending on how touchy we feel the pull request is, we could:
  • Test the union of this pull request, Make NTO components an optional OpenShift feature cluster-node-tuning-operator#524, and the origin pull-request in no-caps cluster-bot to confirm the setup is happy. Or...
  • Skip pre-testing, just merge this pull request and the origin one, and check the no-caps periodic to see if we need any additional tweaks (also, the no-caps periodic seems sad in 4.13 at the moment, but I'll dig into that separately).

And yes, once we are ready to go-ahead with this pull request, we can override upgrade-out-of-change, because adding a new cap is expected to be a one-way gate.

[dagrayvid]

/retest

Now that the openshift/origin#27657 has merged

[dagrayvid]

@wking, the e2e-aws-ovn test in on openshift/cluster-node-tuning-operator#524 is now passing, since we merged openshift/origin#27657.

Is there anything else we should be looking out for from the no-capabilities periodic, before merging this PR?

[dagrayvid]

@petr-muller can you take another look at this PR now?

[dagrayvid]

/unhold

[dagrayvid]

@LalatenduMohanty @wking @petr-muller I believe this PR is ready to merge, PTAL.

[wking]

/lgtm

[wking]

This test will never pass on capability-bumps, because the CVO wants to implicitly enable the rollback-removed capability, but the cap is no longer part of the CRD enum:

/override ci/prow/e2e-agnostic-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade-out-of-change

Details

In response to this:

This test will never pass on capability-bumps, because the CVO wants to implicitly enable the rollback-removed capability, but the cap is no longer part of the CRD enum:

/override ci/prow/e2e-agnostic-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@dagrayvid: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.