Make NTO components an optional OpenShift feature

[dagrayvid]

This PR adds the annotation capability.openshift.io/name to all NTO manifests, in order to make NTO an optional OpenShift capability as described in this enhancement.

As of OpenShift 4.11, it is possible to make certain core OpenShift components optional, so that they can be disabled at install. As discussed in PSAP-741, NTO will be made optional in OpenShift 4.13.

NTO will continue to be enabled by default, and can be re-enabled after install on clusters where it has been disabled.

This PR cannot be merged until the NodeTuning feature is registered in the API.

/cc @jmencak

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dagrayvid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dagrayvid]

/hold

need the openshift/api PR to merge first

[jmencak]

As described in the enhancement this PR is adding annotation capability.openshift.io/name.
/lgtm

Perhaps it might be useful to add the link to the description of the PR.

[jmencak]

/retest
Why the change from "node-tuning" to "NodeTuning"?

[dagrayvid]

Why the change from "node-tuning" to "NodeTuning"?

@jmencak see bparees comment in openshift/api#1373. "CamelCase" is going to be the standard capitalization for these going forwards. There will be no point in retesting this PR until the openshift/api PR merges, as no NTO manifests will be applied to the cluster until the feature is registered in the API.

[jmencak]

Thank you for explanation, David.
/lgtm

[dagrayvid]

/retest

Now that the openshift/origin#27657 has merged

[jmencak]

Interesting: failed to find a TuneD Pod for node ip-10-0-145-238.us-west-2.compute.internal
/retest

[dagrayvid]

Interesting: failed to find a TuneD Pod for node ip-10-0-145-238.us-west-2.compute.internal

Thanks for taking a look Jiri. This is actually exactly expected. Until openshift/cluster-version-operator#883 is merged, the CI for this PR is expected to fail. The CVO sees all these NTO manifests with the capability.openshift.io/name: NodeTuning label and decides not to create them since it doesn't know about this capability NodeTuning yet, so even the namespace for NTO will not exist, let alone the operator and tuned Pods.

Once CVO#883 is merged, we should see these return to passing (MUST see this before merging THIS PR)

[dagrayvid]

/retest

[dagrayvid]

/retest

[dagrayvid]

/unhold

[openshift-ci]

@dagrayvid: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.