Changes for NodeTuning cluster capability#27657
Conversation
$ go get github.com/openshift/api@5ad311dde2264b659a256a17c27f1836fb50e85d $ go mod tidy $ go mod vendor
|
/cc @wking |
dagrayvid
force-pushed
the
optional-node-tuning
branch
from
02be4fe to
8d7b85a
Compare
|
/retest |
1 similar comment
|
/retest |
wking
left a comment
wking
left a comment
There was a problem hiding this comment.
Cluster-bot run, via:
test e2e 4.13,openshift/origin#27657,openshift/cluster-version-operator#883,openshift/cluster-node-tuning-operator#524 aws,no-capabilities
gives:
$ curl -s https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-launch-aws-modern/1615473375369498624/build-log.txt | grep 'oc explain should contain proper spec'
started: 1/37/414 "[sig-cli] oc explain should contain proper spec+status for CRDs [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]"
passed: (27.1s) 2023-01-17T23:23:09 "[sig-cli] oc explain should contain proper spec+status for CRDs [apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]"/lgtm
|
/assign @pweil- |
|
/assign @bparees As you are aware of the plans to make NTO optional |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, dagrayvid, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
|
The failing e2e-gcp- tests are related to the issues on build04, being tracked in OHSS-18195 |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/hold Revision 8d7b85a was retested 3 times: holding |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/retest |
|
I'm seeing this same failure for ci/prow/e2e-gcp-ovn-upgrade in other pending PRs, it does not seem related to this change. /unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@bparees @wking, given that the e2e-gcp-ovn-upgrade failure seems unrelated to this change, what do you think about overriding e2e-gcp-ovn-upgrade for this PR? This was done for the 1.26 rebase, and openshift/origin #27679. Context in this thread and this bug. |
|
opened https://issues.redhat.com/browse/OCPBUGS-6796 /override ci/prow/e2e-gcp-ovn-upgrade |
|
@bparees: Overrode contexts on behalf of bparees: ci/prow/e2e-gcp-ovn-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The e2e-gcp-ovn failure is a known cluster-monitoring-operator issue: https://issues.redhat.com/browse/OCPBUGS-3923 /retest |
6 participants
This PR updates the openshift/api dependency to bring in the new NodeTuning capability.
This PR also adds NodeTuning CRDs to the set that can be ignored when cluster capabilities are set to None, in test/extended/cli/explain.go. An https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-nod[…]ode-tuning-operator-master-e2e-aws-ovn/1603285604148187136 can be seen in the pending NTO PR#524.
See also the pending CVO PR which depends on this change.