Skip to content

OCPBUGS-6030: Rebase onto kube v1.26#1432

Merged
openshift-merge-robot merged 2335 commits into
openshift:masterfrom
sanchezl:rebase-1.26
Jan 31, 2023
Merged

OCPBUGS-6030: Rebase onto kube v1.26#1432
openshift-merge-robot merged 2335 commits into
openshift:masterfrom
sanchezl:rebase-1.26

Conversation

@sanchezl
Copy link
Copy Markdown

@sanchezl sanchezl commented Dec 5, 2022

Rebase onto kubernetes/kubernetes@v1.26.0.

k8s-release-robot and others added 30 commits November 10, 2022 17:30
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
The resource.k8s.io/ClaimTemplate only gets referenced by name, therefore the
changes to the core API are limited.
These tests print a v1.Pod with Sprintf, which includes the new field even when
it is empty.
This adds a new resource.k8s.io API group with v1alpha1 as version. It contains
four new types: resource.ResourceClaim, resource.ResourceClass, resource.ResourceClaimTemplate, and
resource.PodScheduling.
This is needed for "kubectl get". It depends on the generated swagger docs.
This is the result of

   cd staging/src/k8s.io/api && UPDATE_COMPATIBILITY_FIXTURE_DATA=true go test ./...
This is in response to review feedback. Checking for valid node names and the
set property catches programming mistakes in the components that have write
permission.
It's new code, so we should follow the latest recommendations for logging.
This will be used for different individual packages. A separate repo
is better than reusing something like component-helpers because dependencies
will be different.
This is similar to the support code for generic ephemeral inline volumes.
Differences:
- to avoid stuttering, the functions are just resourceclaim.Name and
  resourceclaim.IsForPod
- resourceclaim.Name returns the right name for both cases (template
  and reference), which will simplify some code

Other helper functions check some simple status conditions.
The controller uses the exact same logic as the generic ephemeral inline volume
controller, just for inline ResourceClaimTemplate -> ResourceClaim.

In addition, it supports removal of pods from the ReservedFor field when those
pods are known to not need the claim anymore. At the moment, only this special
case is supported. Removal of arbitrary objects would imply granting full read
access to all types to determine whether a) an object is gone and b) if the
current incarnation is the one which is listed in ReservedFor. This may get
added later.
update documentation after code freeze
…s-beta-enable-e2e-test

Add e2e test for job pod failure policy used to match pod disruption
due to redesign where we changed from new endpoint to /apis. The expected error was not also changed.

Caught by e2e tests when feature enabled. Should have been caught by unit test first but it was implemented without root /apis. Unit test also fixed
so that aggregated-apiservers can also take advantage. discovered by e2e tests with feature enabled
some subresources were not properly included in the array due to pointers becoming stale over a resize
@bertinatto
Copy link
Copy Markdown
Member

/test e2e-gcp

@wallylewis
Copy link
Copy Markdown

/retest-required

4 similar comments
@bertinatto
Copy link
Copy Markdown
Member

/retest-required

@bertinatto
Copy link
Copy Markdown
Member

/retest-required

@bertinatto
Copy link
Copy Markdown
Member

/retest-required

@soltysh
Copy link
Copy Markdown

soltysh commented Jan 30, 2023

/retest-required

Copy link
Copy Markdown

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci Bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jan 30, 2023
@soltysh
Copy link
Copy Markdown

soltysh commented Jan 30, 2023

/test e2e-gcp

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sanchezl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2023
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 7dab57f and 2 for PR HEAD 5f4e61b in total

@bertinatto
Copy link
Copy Markdown
Member

/test e2e-aws-csi
Checking if the snapshot test is permafailing

@soltysh
Copy link
Copy Markdown

soltysh commented Jan 30, 2023

/test e2e-gcp

@wallylewis
Copy link
Copy Markdown

/test e2e-aws-ovn-cgroupsv2

@wallylewis
Copy link
Copy Markdown

/test e2e-aws-ovn-fips /test e2e-aws-ovn-crun

@wallylewis
Copy link
Copy Markdown

/test e2e-aws-ovn-cgroupsv2

@bertinatto
Copy link
Copy Markdown
Member

/test e2e-aws-csi

@wallylewis
Copy link
Copy Markdown

/retest-required

@soltysh
Copy link
Copy Markdown

soltysh commented Jan 31, 2023

/test e2e-gcp-ovn-upgrade
/test e2e-aws-ovn-cgroupsv2

@bertinatto
Copy link
Copy Markdown
Member

/test e2e-gcp-ovn-upgrade

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 31, 2023

@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-upgrade 8843175741b944044ff160e937ded33de6bf55c6 link true /test e2e-azure-upgrade
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade 5f4e61b link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Copy Markdown

soltysh commented Jan 31, 2023

Based on the discussion with TRT the failure from this test is not related with this bump, but rather a pre-existing problem that's being tracked separately
/override ci/prow/e2e-gcp-ovn-upgrade

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 31, 2023

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

Based on the discussion with TRT the failure from this test is not related with this bump, but rather a pre-existing problem that's being tracked separately
/override ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 083e3f3 into openshift:master Jan 31, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@sanchezl: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-6030 has not been moved to the MODIFIED state.

Details

In response to this:

Rebase onto kubernetes/kubernetes@v1.26.0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.