Skip to content

Add e2e test for oc downloads links #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Nov 18, 2019
Merged

Add e2e test for oc downloads links #344

openshift-merge-robot merged 2 commits into from
Nov 18, 2019

Conversation

@benjaminapetersen
Copy link
Contributor

@benjaminapetersen benjaminapetersen commented Nov 12, 2019 

go test -run TestDownloadsEndpoint -count 1
checking for console-operator availability
found operator deployment
link for Download oc for Linux 200 OK (https://console-openshift-console.apps.bpetersen.devcluster.openshift.com/amd64/linux/oc.tar)
link for Download oc for Mac 200 OK (https://console-openshift-console.apps.bpetersen.devcluster.openshift.com/amd64/mac/oc.zip)
link for Download oc for Windows 200 OK (https://console-openshift-console.apps.bpetersen.devcluster.openshift.com/amd64/windows/oc.zip)
PASS
ok  	github.com/openshift/console-operator/test/e2e	5.274s

/assign @spadgett

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 12, 2019
@benjaminapetersen benjaminapetersen mentioned this pull request Nov 12, 2019
Merged
jhadvig
jhadvig approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit, otherwise the test is looking good 👍
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@jhadvig
Copy link
Member

jhadvig commented Nov 13, 2019

/retest

1 similar comment
@jhadvig
Copy link
Member

jhadvig commented Nov 13, 2019

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Nov 13, 2019

@jhadvig will need a new lgtm due to the nit fix.

jhadvig
jhadvig requested changes Nov 13, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminapetersen there is still error in the verify where we have the

test/e2e/metrics_test.go:110:6: httpOK redeclared in this block
previous declaration at test/e2e/util_http.go:53:34
test/e2e/metrics_test.go:117:6: getRequest redeclared in this block
previous declaration at test/e2e/util_http.go:20:44

we can remove those two funcs from metrics_test.go

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Nov 14, 2019

Ah, yes, I borrowed these funcs from the prev test, but moved them to util_http.go there so they could be shared with future tests:

test/e2e/metrics_test.go:110:6: httpOK redeclared in this block
previous declaration at test/e2e/util_http.go:53:34
test/e2e/metrics_test.go:117:6: getRequest redeclared in this block
previous declaration at test/e2e/util_http.go:20:44

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Nov 14, 2019

Didn't flag as an actual rebase issue.
This should pass pretty fast now.

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Nov 15, 2019

/retest

TestRemoved seems kinda flaky yet?

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Nov 15, 2019 •
edited
Loading

Added a retry to the TestRemoved() e2e. I think we need a bit of time to allow terminated resources to be removed for cleanup, else it looks like the operator is not working properly.

3 tries, willing to ignore failures on the first 2.

@benjaminapetersen benjaminapetersen mentioned this pull request Nov 15, 2019
Merged
@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Nov 15, 2019

@jhadvig @spadgett think we are good to go here.

jhadvig
jhadvig approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e7ed244 into openshift:master Nov 18, 2019
@benjaminapetersen benjaminapetersen deleted the test/e2e/downloads branch November 18, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@spadgett spadgett

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benjaminapetersen @jhadvig @openshift-ci-robot @spadgett @openshift-merge-robot